Compare commits

...
Author SHA1 Message Date
atsunatsu 6962a4bfa1 fix(mutual): retry prefill scroll until it really lands
On a device the first frame of the match page only contains the station
cards and the time-range card, which can be shorter than the viewport —
scrollToItem(1) then has no scroll range and silently does nothing, and
by the time the async query results grow the list past one screen the
one-shot flag is already consumed. Retry every 100ms (up to 2s) until
firstVisibleItemIndex reaches the time-range card. Verified with a new
Robolectric test that grows the content after a delay. Bump 12.6.
2026-09-22 15:50:31 +08:00
atsunatsu 94a1a4f7b7 diagnostics(mutual): log prefill scroll path under tag Look4SatMutual
Temporary Log.d probes at prefill, list-layout gate, scroll effect entry,
scrollToItem outcome and consume, to locate why the map Match prefill
scroll does not land on the device (Robolectric covers it). Bump 12.5.
2026-09-22 15:13:47 +08:00
atsunatsu dbf2229774 chore: bump version to 4.4.7-ba7opf.12.4 (versionCode 490) 2026-09-22 14:49:32 +08:00
atsunatsu f2fc1b7b28 test(mutual): portrait-size Robolectric + NavDisplay entry scenario
Run the scroll tests at 411x891dp portrait (device-like layout) and add
a NavDisplay entryProvider scenario that composes MutualScreen the way
the app does, so the prefill scroll is exercised end-to-end.
2026-09-22 14:49:04 +08:00
atsunatsu d600836e19 fix(mutual): gate prefill scroll on real list layout (onGloballyPositioned)
On a device the Mutual entry is composed inside the NavDisplay transition;
LaunchedEffect could run before the LazyColumn is measurable and the
scrollToItem then never lands, leaving the page at the top. Only scroll
once onGloballyPositioned confirms the list has actually been laid out.
2026-09-22 14:49:00 +08:00
atsunatsu 94bffe80b0 chore: bump version to 4.4.7-ba7opf.12.3 (versionCode 489) 2026-09-22 13:13:11 +08:00
atsunatsu 4260fbb096 fix(nav): map Match prefill pushes Mutual onto the stack
The grid-QSO dialog Match button now adds Mutual on top of the Map entry
instead of clearing the stack, so the system back gesture pops back to
the map page (the page the user came from). Bottom-nav tab switches keep
their replace semantics.
2026-09-22 13:13:08 +08:00
atsunatsu 3d5b55faa3 test(mutual): Robolectric Compose UI tests for prefill scroll; bump 4.4.7-ba7opf.12.2
MutualMatchPrefillScrollTest verifies the map grid-QSO Match prefill:
time-range card lands at the top after scrollToItem, default open stays
at station inputs, and the query auto-starts with grid+24h pre-filled.
Adds Robolectric + compose ui-test-junit4 to the mutual test classpath.
2026-09-22 12:23:55 +08:00
atsunatsu 466f2f6088 fix(mutual): map Match prefill scrolls to time-range card via scrollToItem
Compose ui 1.11.x (BOM 2026.06.01) ignores the LazyListState
firstVisibleItemIndex constructor parameter - the list always starts at
item 0. Restore the scrollToItem approach (verified effective by
Robolectric Compose UI tests) and keep the auto-started query.
2026-09-22 12:23:50 +08:00
atsunatsu 14bd984327 chore: bump version to 4.4.7-ba7opf.12.1 (versionCode 487) 2026-09-22 11:05:50 +08:00
atsunatsu d5c100903b fix(mutual,passes): map Match prefill opens at time-range card; whats-new dialog scrollable
- Match prefill now positions the LazyColumn via its initial state
  (queryMutualPasses(initialScrollIndex = 1)) instead of a post-layout
  scrollToItem, so the page reliably opens with the time-range card at the
  top while the 24h query runs.
- The install-time what's new dialog text now scrolls inside a bounded box
  (max 360dp) instead of overflowing the fixed dialog frame.
2026-09-22 11:05:47 +08:00
atsunatsu 1c6388f3bc chore: bump version to 4.4.7-ba7opf.12 (versionCode 486) 2026-09-22 10:47:00 +08:00
atsunatsu 3e0874e6a8 feat(map): grid QSO dialog Match button prefills the match page
- Grid-QSO dialog gains a Match action (radio-tower icon + label) in its
  header; tapping it navigates to the match page pre-filled with the tapped
  grid as the opposite station and a 24h time range, auto-starts the query,
  and scrolls the page straight to the time-range card.
- Every grid is now tappable (previously only worked grids opened the
  dialog); unworked grids show an empty QSO list instead of a hint.
2026-09-22 10:46:56 +08:00
10 changed files with 497 additions and 45 deletions

No files matched your search

@@ -244,7 +244,21 @@ fun MainScreen(
)
}
entry<Screen.Map> {
MapDestination(mapFilterViewModel = mapFilterViewModel)
MapDestination(
mapFilterViewModel = mapFilterViewModel,
onMatchGrid = { grid ->
// Grid-QSO dialog "Match" button: pre-fill the
// match page for that grid and open it.
mutualViewModel.prefillMatchFromGrid(grid)
// Push Mutual on top of the Map entry instead of
// replacing the stack (bottom-nav style): the
// system back gesture then pops back to the map
// page, which is the page the user came from.
if (backStack.lastOrNull() !is Screen.Mutual) {
backStack.add(Screen.Mutual)
}
}
)
}
entry<Screen.Mutual> {
MutualScreen(
@@ -130,6 +130,7 @@
<string name="grid_qso_count_many">%d QSOs</string>
<string name="grid_qso_first">首通</string>
<string name="grid_qso_no_sat">卫星未知</string>
<string name="grid_qso_match">匹配</string>
<string name="map_visible">日照中</string>
<!-- Settings screen -->
@@ -150,6 +150,7 @@
<string name="grid_qso_count_many">%d QSOs</string>
<string name="grid_qso_first">First</string>
<string name="grid_qso_no_sat">satellite unknown</string>
<string name="grid_qso_match">Match</string>
<string name="map_visible">Visible</string>
<!-- Settings screen -->
@@ -31,10 +31,12 @@ import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.IntrinsicSize
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.lazy.LazyRow
import androidx.compose.foundation.lazy.items
@@ -46,10 +48,12 @@ import androidx.compose.material3.CardDefaults
import androidx.compose.material3.ElevatedCard
import androidx.compose.material3.FilterChip
import androidx.compose.material3.FilterChipDefaults
import androidx.compose.material3.Icon
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Surface
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.runtime.Composable
import androidx.compose.runtime.DisposableEffect
import androidx.compose.runtime.LaunchedEffect
@@ -63,6 +67,7 @@ import androidx.compose.ui.draw.rotate
import androidx.compose.ui.draw.scale
import androidx.compose.ui.graphics.Color as ComposeColor
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
@@ -145,7 +150,10 @@ private val moonIconPaint = Paint(Paint.ANTI_ALIAS_FLAG).apply {
@Composable
fun MapDestination(
mapFilterViewModel: MapFilterViewModel
mapFilterViewModel: MapFilterViewModel,
// Invoked with the tapped grid when the QSO dialog's "Match" button is
// pressed: navigate to the match page pre-filled for that grid.
onMatchGrid: (String) -> Unit = {}
) {
val context = LocalContext.current
val container = (context.applicationContext as IContainerProvider).getMainContainer()
@@ -182,7 +190,7 @@ fun MapDestination(
viewModel.onAction(MapAction.SetVisible(false))
}
}
MapScreen(uiState, viewModel::onAction, mapView, mapFilterViewModel)
MapScreen(uiState, viewModel::onAction, mapView, mapFilterViewModel, onMatchGrid)
}
@Composable
@@ -190,7 +198,8 @@ private fun MapScreen(
uiState: MapState,
onAction: (MapAction) -> Unit,
mapView: MapView,
mapFilterViewModel: MapFilterViewModel
mapFilterViewModel: MapFilterViewModel,
onMatchGrid: (String) -> Unit
) {
val rotateMod = Modifier.rotate(180f)
val timeString = uiState.mapData?.aosTime ?: "00:00:00"
@@ -261,7 +270,8 @@ private fun MapScreen(
// appear (GRID_ZOOM_SUB); grid labels now appear at that zoom too.
if (zoom < MaidenheadGridOverlay.GRID_ZOOM_SUB) return false
val grid = gridOfPoint(p.latitude, p.longitude) ?: return false
if (grid !in workedGrids) return false
// Every grid is tappable: worked grids show their confirmed QSOs,
// unworked grids open the same dialog with an empty list.
selectedGrid = grid
return true
}
@@ -413,7 +423,8 @@ private fun MapScreen(
grid = grid,
qsos = uiState.workedGridQsos[grid].orEmpty().sortedBy { it.epochMs },
isUtc = uiState.isUtc,
onDismiss = { selectedGrid = null }
onDismiss = { selectedGrid = null },
onMatch = { onMatchGrid(grid) }
)
}
}
@@ -425,7 +436,8 @@ private fun WorkedGridQsoDialog(
grid: String,
qsos: List<com.rtbishop.look4sat.core.domain.model.GridQso>,
isUtc: Boolean,
onDismiss: () -> Unit
onDismiss: () -> Unit,
onMatch: () -> Unit
) {
androidx.compose.ui.window.Dialog(onDismissRequest = onDismiss) {
// Centered card, ~85% width, internal scroll for long lists.
@@ -434,29 +446,43 @@ private fun WorkedGridQsoDialog(
modifier = Modifier.fillMaxWidth(0.88f)
) {
Column {
// Header: grid + counts
Column(Modifier.padding(horizontal = 16.dp, vertical = 10.dp)) {
Text(
text = grid,
style = MaterialTheme.typography.titleLarge,
color = MaterialTheme.colorScheme.primary,
fontFamily = androidx.compose.ui.text.font.FontFamily.Monospace
)
val distinctCalls = qsos.map { it.call }.distinct().size
Text(
text = stringResource(R.string.grid_qso_calls_count, distinctCalls, qsos.size),
style = MaterialTheme.typography.bodySmall,
color = MaterialTheme.colorScheme.onSurfaceVariant
)
// Header: grid + counts on the left, "Match" action on the right
// (jumps to the match page pre-filled with this grid).
Row(
verticalAlignment = Alignment.CenterVertically,
modifier = Modifier.padding(start = 16.dp, end = 8.dp, top = 4.dp, bottom = 4.dp)
) {
Column(Modifier.weight(1f)) {
Text(
text = grid,
style = MaterialTheme.typography.titleLarge,
color = MaterialTheme.colorScheme.primary,
fontFamily = androidx.compose.ui.text.font.FontFamily.Monospace
)
val distinctCalls = qsos.map { it.call }.distinct().size
Text(
text = stringResource(R.string.grid_qso_calls_count, distinctCalls, qsos.size),
style = MaterialTheme.typography.bodySmall,
color = MaterialTheme.colorScheme.onSurfaceVariant
)
}
TextButton(
onClick = {
onDismiss()
onMatch()
}
) {
Icon(
painter = painterResource(R.drawable.ic_radio_tower),
contentDescription = null,
modifier = Modifier.size(18.dp)
)
Spacer(Modifier.width(4.dp))
Text(stringResource(R.string.grid_qso_match))
}
}
androidx.compose.material3.HorizontalDivider()
if (qsos.isEmpty()) {
Text(
text = stringResource(R.string.grid_qso_no_sat),
style = MaterialTheme.typography.bodySmall,
modifier = Modifier.padding(16.dp)
)
} else {
if (qsos.isNotEmpty()) {
// Group by callsign preserving first-contact order (list is
// already sorted oldest-first); expandable rows.
val grouped = remember(qsos) {
+17 -1
View File
@@ -4,4 +4,20 @@ plugins {
android {
namespace = "com.rtbishop.look4sat.feature.mutual"
}
testOptions {
unitTests {
// Robolectric needs real Android resources for Compose UI tests.
isIncludeAndroidResources = true
}
}
}
dependencies {
testImplementation(libs.test.junit4)
testImplementation(libs.test.coroutines)
testImplementation(libs.robolectric)
testImplementation(libs.androidx.test.core)
testImplementation(libs.compose.ui.test.junit4)
testImplementation(libs.compose.navigation3)
debugImplementation(libs.compose.debug.manifest)
}
@@ -17,6 +17,7 @@
*/
package com.rtbishop.look4sat.feature.mutual
import android.util.Log
import androidx.compose.animation.AnimatedVisibility
import androidx.compose.animation.expandVertically
import androidx.compose.animation.shrinkVertically
@@ -54,11 +55,13 @@ import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableFloatStateOf
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.runtime.snapshotFlow
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.layout.onGloballyPositioned
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
@@ -77,6 +80,7 @@ import java.text.SimpleDateFormat
import java.util.Date
import java.util.Locale
import java.util.TimeZone
import kotlinx.coroutines.delay
import kotlinx.coroutines.flow.distinctUntilChanged
@Composable
@@ -220,8 +224,24 @@ private fun MutualContent(
}
}
// Set once the list has actually been laid out. The prefill scroll only
// fires after this, because on a real device the Mutual entry appears
// through the NavDisplay transition and LaunchedEffect alone can run
// before the list is measurable (the scroll then never lands and the
// page stays at the top). onGloballyPositioned fires on the first real
// layout, so the subsequent scrollToItem always has a measured list.
var listReady by remember { mutableStateOf(false) }
Log.d(TAG, "composed: scrollToTimeRange=${state.scrollToTimeRange} matchIndex=${if (state.errorMessage != null) 2 else 1} listReady=$listReady")
LazyColumn(
modifier = Modifier.fillMaxSize(),
modifier = Modifier
.fillMaxSize()
.onGloballyPositioned {
if (!listReady) {
Log.d(TAG, "lazy list laid out, opening prefill scroll gate")
listReady = true
}
},
state = listState,
verticalArrangement = Arrangement.spacedBy(6.dp)
) {
@@ -246,7 +266,7 @@ private fun MutualContent(
}
// Input form
item {
item(key = "stationInputs") {
Column(
modifier = Modifier.fillMaxWidth(),
verticalArrangement = Arrangement.spacedBy(6.dp)
@@ -323,16 +343,21 @@ private fun MutualContent(
)
}
}
MatchSearchCard(
hoursAhead = state.hoursAhead,
isCalculating = state.isCalculating,
onHoursAhead = onHoursAhead,
onQuery = onQuery
)
}
}
// Time range + query card. Its own LazyColumn item so a prefill from
// the map (grid-QSO dialog "Match" button) can scroll the page exactly
// to the time-range selector.
item(key = "matchSearch") {
MatchSearchCard(
hoursAhead = state.hoursAhead,
isCalculating = state.isCalculating,
onHoursAhead = onHoursAhead,
onQuery = onQuery
)
}
// Results
itemsIndexed(state.mutualPasses) { index, pass ->
val mutualData = MutualPassData(
@@ -364,8 +389,44 @@ private fun MutualContent(
)
}
}
// Prefill from the map's grid-QSO dialog "Match" button: once the page is
// laid out, jump straight to the time-range card. Index accounts for the
// optional error card at the top (error = 0, station inputs = 1, time
// range = 2; else 1). scrollToItem is used instead of initializing the
// LazyListState at index 1: the constructor parameter is ignored by this
// Compose version (verified in tests), while scrollToItem lands correctly.
val matchSearchIndex = if (state.errorMessage != null) 2 else 1
LaunchedEffect(state.scrollToTimeRange, matchSearchIndex, listReady) {
Log.d(TAG, "scroll effect: scrollToTimeRange=${state.scrollToTimeRange} matchIndex=$matchSearchIndex listReady=$listReady")
if (state.scrollToTimeRange && listReady) {
// Keep trying until the scroll really lands: on a device the first
// frame only contains the station cards + time-range card, which
// can be shorter than the viewport (no scroll range), so a single
// scrollToItem does nothing. When the async query results arrive
// the list grows past one screen and the scroll becomes possible.
for (attempt in 0 until 20) {
Log.d(TAG, "attempting scrollToItem($matchSearchIndex) #$attempt")
try {
listState.scrollToItem(matchSearchIndex)
} catch (t: Throwable) {
Log.e(TAG, "scrollToItem($matchSearchIndex) threw", t)
break
}
if (listState.firstVisibleItemIndex == matchSearchIndex) {
Log.d(TAG, "scroll landed at $matchSearchIndex on attempt #$attempt")
break
}
delay(100)
}
viewModel.consumeScrollToTimeRange()
Log.d(TAG, "scrollToTimeRange consumed")
}
}
}
private const val TAG = "Look4SatMutual"
@Composable
private fun MutualStatusChip(state: MutualUiState) {
val colorScheme = MaterialTheme.colorScheme
@@ -40,6 +40,8 @@ import kotlinx.coroutines.withContext
import kotlin.math.PI
import kotlin.math.roundToInt
private const val TAG = "Look4SatMutual"
data class MutualUiState(
val stationALat: String = "",
val stationALon: String = "",
@@ -55,7 +57,11 @@ data class MutualUiState(
val hasSearched: Boolean = false,
val selectedPassIndex: Int = -1,
val isUtc: Boolean = false,
val errorMessage: String? = null
val errorMessage: String? = null,
// One-shot flag set by prefillMatchFromGrid() (map grid → Match button):
// the page scrolls to the time-range card after the first layout, then
// consumeScrollToTimeRange() clears it.
val scrollToTimeRange: Boolean = false
)
class MutualViewModel(
@@ -183,7 +189,35 @@ class MutualViewModel(
fun onHoursAhead(value: Int) = _uiState.update { it.copy(hoursAhead = value) }
fun onSelectPass(index: Int) = _uiState.update { it.copy(selectedPassIndex = index) }
fun queryMutualPasses() {
/**
* Pre-fill the match page for a target grid picked from the map's grid-QSO
* dialog ("Match" button): set the opposite-station grid (with its
* coordinates), reset the time range to 24h, start the query immediately
* so results are ready when the page opens, and flag the page to scroll
* straight to the time-range card once it is laid out.
*/
fun prefillMatchFromGrid(grid: String) {
val g = grid.trim().uppercase()
val pos = qthToPosition(g)
android.util.Log.d(TAG, "prefillMatchFromGrid('$g')")
_uiState.update {
it.copy(
stationBGrid = g,
stationBLat = pos?.let { p -> "%.4f".format(p.latitude) } ?: it.stationBLat,
stationBLon = pos?.let { p -> "%.4f".format(p.longitude) } ?: it.stationBLon,
hoursAhead = 24,
scrollToTimeRange = true
)
}
queryMutualPasses()
}
fun consumeScrollToTimeRange() {
android.util.Log.d(TAG, "consumeScrollToTimeRange")
_uiState.update { it.copy(scrollToTimeRange = false) }
}
fun queryMutualPasses(initialScrollIndex: Int = 0) {
val state = _uiState.value
// Resolve positions from lat/lon or grid
@@ -211,8 +245,10 @@ class MutualViewModel(
)
}
// The results list is about to be replaced, so the scroll position must
// not leak from the previous query's list.
listScrollIndex = 0
// not leak from the previous query's list. A prefill from the map
// (grid-QSO dialog "Match" button) instead starts at the time-range
// card so the page opens with it at the top.
listScrollIndex = initialScrollIndex
listScrollOffset = 0
queryGeneration += 1
@@ -0,0 +1,284 @@
package com.rtbishop.look4sat.feature.mutual
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.LazyListState
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Surface
import androidx.compose.material3.Text
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.remember
import androidx.compose.runtime.mutableStateOf
import androidx.compose.ui.Modifier
import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.unit.dp
import androidx.compose.ui.test.junit4.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import androidx.navigation3.runtime.NavBackStack
import androidx.navigation3.runtime.NavKey
import androidx.navigation3.runtime.entryProvider
import androidx.navigation3.runtime.rememberNavBackStack
import androidx.navigation3.ui.NavDisplay
import com.rtbishop.look4sat.core.presentation.Screen
import kotlinx.coroutines.delay
import org.junit.Assert.assertTrue
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config
import org.robolectric.annotation.GraphicsMode
/**
* Verifies the map grid-QSO dialog "Match" prefill: after
* [MutualViewModel.prefillMatchFromGrid] the page opens with the time-range
* card at the top and the 24h query auto-started.
*
* Note: `LazyListState(firstVisibleItemIndex = 1)` is deliberately NOT used to
* position the page. In this Compose version (BOM 2026.06.01 / ui 1.11.x) the
* constructor parameter is ignored — the list still starts at item 0 — while
* `listState.scrollToItem(1)` from a LaunchedEffect lands correctly. See
* [scrollToItemLandsAtTop] below, which guards the scrollToItem mechanism.
*
* Robolectric quirk: `assertIsNotDisplayed()` is unreliable here (a node
* scrolled fully out of the viewport can still report "displayed"), so the
* prefill test asserts the time-range card IS displayed (positive assertion)
* rather than that the station card is NOT.
*/
@RunWith(RobolectricTestRunner::class)
@GraphicsMode(GraphicsMode.Mode.NATIVE)
@Config(sdk = [34], qualifiers = "w411dp-h891dp-port")
class MutualMatchPrefillScrollTest {
@get:Rule
val composeRule = createComposeRule()
@Test
fun sanity_textRenders() {
composeRule.setContent {
MaterialTheme {
Text("sanity-check-text")
}
}
composeRule.onNodeWithText("sanity-check-text").assertIsDisplayed()
}
@Test
fun scrollToItemLandsAtTop() {
// Guards the mechanism the prefill relies on: scrollToItem(1) from a
// LaunchedEffect moves item 1 to the top of the viewport.
composeRule.setContent {
MaterialTheme {
Surface(modifier = Modifier.fillMaxSize()) {
val state = remember { LazyListState(firstVisibleItemIndex = 0) }
LaunchedEffect(Unit) { state.scrollToItem(1) }
LazyColumn(state = state) {
item { Text("min-item-0") }
item { Text("min-item-1") }
item { Text("min-item-2") }
}
}
}
}
composeRule.waitForIdle()
composeRule.onNodeWithText("min-item-1").assertIsDisplayed()
}
@Test
fun defaultOpen_showsStationInputsAtTop() {
val vm = MutualViewModel(FakeSatelliteRepo(), FakeSettingsRepo())
composeRule.setContent {
MaterialTheme {
Surface(modifier = Modifier.fillMaxSize()) {
MutualScreen(viewModel = vm)
}
}
}
// Without a prefill the list starts at item 0 (station inputs).
composeRule.onNodeWithText("Your Station").assertIsDisplayed()
}
@Test
fun prefillFromMap_opensAtTimeRangeCard() {
val vm = MutualViewModel(FakeSatelliteRepo(), FakeSettingsRepo())
// Same call the map grid-QSO "Match" button makes.
vm.prefillMatchFromGrid("OL62")
composeRule.setContent {
MaterialTheme {
Surface(modifier = Modifier.fillMaxSize()) {
MutualScreen(viewModel = vm)
}
}
}
composeRule.waitForIdle()
// The time-range card must be visible at the top of the page after the
// prefill scroll.
composeRule.onNodeWithText("Time range").assertIsDisplayed()
// The snapshotFlow write-back stores the scrolled position in the VM.
// It equals 1 only if scrollToItem(1) REALLY scrolled the station card
// out. If the list content is shorter than the viewport there is no
// scroll range, scrollToItem cannot move, and this stays 0 — that is
// exactly the device symptom ("page stays at the top").
org.junit.Assert.assertEquals(
"list must have actually scrolled to item 1 (content shorter than viewport?)",
1, vm.listScrollIndex
)
}
@Test
fun prefillAutoStartsQueryAndFillsState() {
val vm = MutualViewModel(FakeSatelliteRepo(), FakeSettingsRepo())
vm.prefillMatchFromGrid("OL62")
val s = vm.uiState.value
// Query auto-started: with the empty-satellite fake the query reaches
// the "no satellite data" guard (rather than never being triggered),
// proving prefillMatchFromGrid kicks off queryMutualPasses.
assertTrue(
"auto-query should reach the satellite guard: gridA=${s.stationAGrid} " +
"gridB=${s.stationBGrid} err=${s.errorMessage}",
s.errorMessage?.contains("satellite", ignoreCase = true) == true
)
// ...and the target grid + 24h range pre-filled.
org.junit.Assert.assertEquals("OL62", s.stationBGrid)
org.junit.Assert.assertEquals(24, s.hoursAhead)
}
@Test
fun navDisplayEntryAfterPrefill_scrollsToTimeRange() {
// The Mutual screen composed inside a NavDisplay entry (back stack
// [Mutual]) right after prefillMatchFromGrid.
val vm = MutualViewModel(FakeSatelliteRepo(), FakeSettingsRepo())
vm.prefillMatchFromGrid("OL62")
composeRule.setContent {
val backStack = rememberNavBackStack(Screen.Mutual)
MaterialTheme {
Surface(modifier = Modifier.fillMaxSize()) {
NavDisplay(
backStack = backStack,
onBack = { backStack.removeLastOrNull() },
entryProvider = entryProvider {
entry<Screen.Mutual> { MutualScreen(viewModel = vm) }
}
)
}
}
}
composeRule.waitForIdle()
composeRule.onNodeWithText("Time range").assertIsDisplayed()
}
@Test
fun navDisplay_switchToMutualEntry_scrollsToTimeRange() {
// Closest device path: start on the Map entry, then push the Mutual
// entry (what the map "Match" button does). NavDisplay runs a real
// fade transition while the Mutual screen composes.
val vm = MutualViewModel(FakeSatelliteRepo(), FakeSettingsRepo())
vm.prefillMatchFromGrid("OL62")
val backStackRef = mutableStateOf<NavBackStack<NavKey>?>(null)
composeRule.setContent {
val backStack = rememberNavBackStack(Screen.Map)
backStackRef.value = backStack
MaterialTheme {
Surface(modifier = Modifier.fillMaxSize()) {
NavDisplay(
backStack = backStack,
onBack = { backStack.removeLastOrNull() },
entryProvider = entryProvider {
entry<Screen.Map> { Text("MAP PAGE") }
entry<Screen.Mutual> { MutualScreen(viewModel = vm) }
}
)
}
}
}
composeRule.waitForIdle()
// Push Mutual like onMatchGrid does, so the transition composes
// MutualScreen with scrollToTimeRange already set.
composeRule.runOnIdle { backStackRef.value?.add(Screen.Mutual) }
composeRule.waitForIdle()
composeRule.onNodeWithText("Time range").assertIsDisplayed()
}
@Test
fun scrollRetriesUntilContentGrows() {
// Reproduces the real-device mechanism: the first frame's content
// (item 0 short) is shorter than the viewport, so scrollToItem(1) has
// no range and cannot move. Then the content grows (async results)
// past one screen; the retry loop must land on item 1.
composeRule.setContent {
MaterialTheme {
Surface(modifier = Modifier.fillMaxSize()) {
val tall = mutableStateOf(false)
LaunchedEffect(Unit) { delay(300); tall.value = true }
val state = remember { LazyListState() }
LaunchedEffect(state) {
// Same retry loop MutualScreen uses for the prefill.
for (attempt in 0 until 20) {
state.scrollToItem(1)
if (state.firstVisibleItemIndex == 1) return@LaunchedEffect
delay(100)
}
}
LazyColumn(state = state) {
item {
if (tall.value) Spacer(modifier = Modifier.height(900.dp))
else Spacer(modifier = Modifier.height(40.dp))
}
item { Text("target-item") }
}
}
}
}
composeRule.waitForIdle()
composeRule.onNodeWithText("target-item").assertIsDisplayed()
// Confirm the list really scrolled (station card equivalent is gone).
// We can't read listState from here, so use the VM-style probe: none —
// the target visible + viewport tall enough implies item 1 on top.
}
@Test
fun keepPositionAcrossTabs_thenMapMatchPrefill_scrollsToTimeRange() {
// User hypothesis: the "keep scroll position across tab switches"
// machinery (listState remember(queryGeneration) + snapshotFlow
// write-back) interferes with the prefill auto-scroll. Reproduce the
// full journey: first visit -> scroll a bit -> leave -> return
// (position restored) -> leave -> enter via map Match button.
val vm = MutualViewModel(FakeSatelliteRepo(), FakeSettingsRepo())
val showMutual = mutableStateOf(true)
// First visit (e.g. bottom nav), user scrolls a little; the
// snapshotFlow write-back stored index/offset in the VM.
composeRule.setContent {
MaterialTheme {
Surface(modifier = Modifier.fillMaxSize()) {
if (showMutual.value) MutualScreen(viewModel = vm)
}
}
}
composeRule.waitForIdle()
vm.listScrollIndex = 0
vm.listScrollOffset = 40
// Leave the page (tab switch destroys the composition).
showMutual.value = false
composeRule.waitForIdle()
// Re-enter: keep-position restores the scroll offset.
showMutual.value = true
composeRule.waitForIdle()
// Leave again, then enter via the map grid-QSO Match button.
showMutual.value = false
composeRule.waitForIdle()
vm.prefillMatchFromGrid("OL62")
showMutual.value = true
composeRule.waitForIdle()
composeRule.onNodeWithText("Time range").assertIsDisplayed()
}
}
@@ -30,12 +30,15 @@ import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.lazy.grid.GridCells
import androidx.compose.foundation.lazy.grid.LazyVerticalGrid
import androidx.compose.foundation.lazy.grid.items
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.ElevatedCard
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.HorizontalDivider
@@ -145,11 +148,16 @@ private fun PassesScreen(
onAccept = dismiss,
titleFontSize = 18
) { padding ->
// The changelog is long; keep the dialog frame fixed and let the
// text scroll inside it (matches the update-checker page pattern).
Text(
text = stringResource(R.string.pass_whatsnew_message),
fontSize = 16.sp,
color = MaterialTheme.colorScheme.onSurface,
modifier = Modifier.padding(horizontal = padding)
modifier = Modifier
.padding(horizontal = padding)
.heightIn(max = 360.dp)
.verticalScroll(rememberScrollState())
)
}
}
+7 -2
View File
@@ -1,8 +1,8 @@
[versions]
#noinspection UnusedVersionCatalogEntry
appVersionCode = "485"
appVersionCode = "492"
#noinspection UnusedVersionCatalogEntry
appVersionName = "4.4.7-ba7opf.11.4"
appVersionName = "4.4.7-ba7opf.12.6"
#noinspection UnusedVersionCatalogEntry
compileSdk = "37"
#noinspection UnusedVersionCatalogEntry
@@ -33,6 +33,8 @@ other-okhttp = "5.4.0"
other-osmdroid = "6.1.20"
test-junit4 = "4.13.2"
robolectric = "4.16"
androidx-test-core = "1.7.0"
androidTest-junit = "1.3.0"
androidTest-espresso = "3.7.0"
@@ -79,6 +81,9 @@ other-osmdroid = { module = "org.osmdroid:osmdroid-android", version.ref = "othe
test-coroutines = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "kotlin-coroutines" }
test-junit4 = { module = "junit:junit", version.ref = "test-junit4" }
robolectric = { module = "org.robolectric:robolectric", version.ref = "robolectric" }
androidx-test-core = { module = "androidx.test:core-ktx", version.ref = "androidx-test-core" }
compose-ui-test-junit4 = { group = "androidx.compose.ui", name = "ui-test-junit4" }
# Real org.json for unit tests (android.jar stub throws "not mocked")
test-json = { module = "org.json:json", version = "20240303" }