Code refactoring (224 B)

App/app/action.c

@@ -380,6 +380,9 @@ void ACTION_Handle(KEY_Code_t Key, bool bKeyPressed, bool bKeyHeld)
             case ACTION_OPT_POWER_HIGH:
             case ACTION_OPT_REMOVE_OFFSET:
         #endif
+    #endif
+    #ifdef ENABLE_FEAT_F4HWN_BEAM
+            case ACTION_OPT_BEAM:
     #endif
                 gBeepToPlay = BEEP_500HZ_60MS_DOUBLE_BEEP_OPTIONAL;
                 return;

App/app/aircopy.c

@@ -158,8 +158,10 @@ static inline const AIRCOPY_Segment_t *AIRCOPY_FindSegmentForOffset(uint16_t off
     return NULL;
 }
 
-static inline void AIRCOPY_CheckComplete(void)
+static inline void AIRCOPY_CheckComplete(uint16_t *num)
 {
+    *num = *num + 1;
+
     const AIRCOPY_TransferMap_t *map = AIRCOPY_GetCurrentMap();
     uint16_t done = gAirCopyBlockNumber + gErrorsDuringAirCopy;
 
@@ -257,12 +259,10 @@ void AIRCOPY_StorePacket(void)
     BK4819_PrepareFSKReceive();
 
     if ((Status & 0x0010U) != 0 || g_FSK_Buffer[0] != 0xABCD || g_FSK_Buffer[35] != 0xDCBA) {
-        gErrorsDuringAirCopy++;
-
         BK4819_ResetFSK();           // <- important
         BK4819_PrepareFSKReceive();  // <- re-arm proprement
 
-        AIRCOPY_CheckComplete();
+        AIRCOPY_CheckComplete(&gErrorsDuringAirCopy);
         return;
     }
 
@@ -270,8 +270,7 @@ void AIRCOPY_StorePacket(void)
 
     uint16_t Crc = CRC_Calculate(&g_FSK_Buffer[1], 2 + 64);
     if (g_FSK_Buffer[34] != Crc) {
-        gErrorsDuringAirCopy++;
+        AIRCOPY_CheckComplete(&gErrorsDuringAirCopy);
-        AIRCOPY_CheckComplete();
         return;
     }
 
@@ -280,36 +279,18 @@ void AIRCOPY_StorePacket(void)
     const AIRCOPY_Segment_t *seg = AIRCOPY_FindSegmentForOffset(Offset);
     
     if (seg == NULL) {
-        gErrorsDuringAirCopy++;
+        AIRCOPY_CheckComplete(&gErrorsDuringAirCopy);
-        AIRCOPY_CheckComplete();
         return;
     }
 
-    if (seg->write_mode == AIRCOPY_WRITE_BYTES)
+    const uint8_t *pData = (const uint8_t *)&g_FSK_Buffer[2];
-    {
-        /* Raw bytes stream, written in 8-byte EEPROM chunks */
-        const uint8_t *p8 = (const uint8_t *)&g_FSK_Buffer[2];
 
     for (unsigned int i = 0; i < 8; i++)
     {
-            EEPROM_WriteBuffer(Offset + (i * 8), p8 + (i * 8));
+        EEPROM_WriteBuffer(Offset + (i * 8), pData + (i * 8));
-        }
-    }
-    else
-    {
-        /* Structured data path (kept as-is) */
-        const uint16_t *pData = &g_FSK_Buffer[2];
-
-        for (unsigned int i = 0; i < 8; i++)
-        {
-            EEPROM_WriteBuffer(Offset, pData);
-            pData += 4;
-            Offset += 8;
-        }
     }
 
-    gAirCopyBlockNumber++;
+    AIRCOPY_CheckComplete(&gAirCopyBlockNumber);
-    AIRCOPY_CheckComplete();
 }
 
 static void AIRCOPY_InitTransfer(bool isSendMode)

App/app/beam.c

@@ -72,34 +72,7 @@ uint16_t      gBeamCopiedChannel = 0xFFFFu;
 uint8_t       gBeamRxWordCount;
 bool          gBeamActive;
 
-static VFO_Info_t gBeamBackupVfo;
 static VFO_Info_t gBeamRadioVfo;
-static uint16_t   gBeamBackupScreenChannel;
-static uint8_t    gBeamVfoIndex;
-static uint8_t    gBeamBackupRxVfoIndex;
-static bool       gBeamHasBackup;
-
-static void BEAM_SaveBackup(void)
-{
-    gBeamVfoIndex = gEeprom.TX_VFO;
-    memcpy(&gBeamBackupVfo, &gEeprom.VfoInfo[gBeamVfoIndex], sizeof(gBeamBackupVfo));
-    gBeamBackupScreenChannel = gEeprom.ScreenChannel[gBeamVfoIndex];
-    gBeamBackupRxVfoIndex = gEeprom.RX_VFO;
-    gBeamHasBackup = true;
-}
-
-static void BEAM_RestoreBackup(void)
-{
-    if (!gBeamHasBackup)
-        return;
-
-    memcpy(&gEeprom.VfoInfo[gBeamVfoIndex], &gBeamBackupVfo, sizeof(gBeamBackupVfo));
-    gEeprom.ScreenChannel[gBeamVfoIndex] = gBeamBackupScreenChannel;
-    gEeprom.RX_VFO = gBeamBackupRxVfoIndex;
-    RADIO_SelectVfos();
-    RADIO_SetupRegisters(true);
-    gBeamHasBackup = false;
-}
 
 static void BEAM_SetRadioToBeamFrequency(void)
 {
@@ -118,58 +91,46 @@ static void BEAM_SetRadioToBeamFrequency(void)
     BK4819_ResetFSK();
 }
 
-static void BEAM_CopyNameFromActiveVfo(char *name)
+static void BEAM_SendPacket(void)
 {
-    memset(name, 0, 16);
+    memset(g_FSK_Buffer, 0, sizeof(g_FSK_Buffer));
+    g_FSK_Buffer[0] = 0xABCDu;
     
-    if (IS_MR_CHANNEL(gBeamBackupVfo.CHANNEL_SAVE)) {
+    BEAM_Payload_t * const payload = (BEAM_Payload_t *)&g_FSK_Buffer[2];
-        SETTINGS_FetchChannelName(name, gBeamBackupVfo.CHANNEL_SAVE);
-    } else {
-        memcpy(name, gBeamBackupVfo.Name, sizeof(gBeamBackupVfo.Name));
-    }
-}
     
-static void BEAM_FillPayload(BEAM_Payload_t *payload)
+    const VFO_Info_t *vfo = &gEeprom.VfoInfo[gEeprom.TX_VFO];
-{
-    memset(payload, 0, sizeof(*payload));
 
     payload->magic = BEAM_PACKET_MAGIC;
     payload->version = BEAM_PACKET_VERSION;
-    payload->rx_frequency = gBeamBackupVfo.freq_config_RX.Frequency;
+    payload->rx_frequency = vfo->freq_config_RX.Frequency;
-    payload->tx_offset_frequency = gBeamBackupVfo.TX_OFFSET_FREQUENCY;
+    payload->tx_offset_frequency = vfo->TX_OFFSET_FREQUENCY;
-    payload->rx_code = gBeamBackupVfo.freq_config_RX.Code;
+    payload->rx_code = vfo->freq_config_RX.Code;
-    payload->tx_code = gBeamBackupVfo.freq_config_TX.Code;
+    payload->tx_code = vfo->freq_config_TX.Code;
-    payload->rx_codetype = gBeamBackupVfo.freq_config_RX.CodeType;
+    payload->rx_codetype = vfo->freq_config_RX.CodeType;
-    payload->tx_codetype = gBeamBackupVfo.freq_config_TX.CodeType;
+    payload->tx_codetype = vfo->freq_config_TX.CodeType;
-    payload->modulation = gBeamBackupVfo.Modulation;
+    payload->modulation = vfo->Modulation;
-    payload->tx_offset_direction = gBeamBackupVfo.TX_OFFSET_FREQUENCY_DIRECTION;
+    payload->tx_offset_direction = vfo->TX_OFFSET_FREQUENCY_DIRECTION;
-    payload->tx_lock = gBeamBackupVfo.TX_LOCK;
+    payload->tx_lock = vfo->TX_LOCK;
-    payload->busy_channel_lock = gBeamBackupVfo.BUSY_CHANNEL_LOCK;
+    payload->busy_channel_lock = vfo->BUSY_CHANNEL_LOCK;
-    payload->output_power = gBeamBackupVfo.OUTPUT_POWER;
+    payload->output_power = vfo->OUTPUT_POWER;
-    payload->channel_bandwidth = gBeamBackupVfo.CHANNEL_BANDWIDTH;
+    payload->channel_bandwidth = vfo->CHANNEL_BANDWIDTH;
-    payload->frequency_reverse = gBeamBackupVfo.FrequencyReverse;
+    payload->frequency_reverse = vfo->FrequencyReverse;
-    payload->dtmf_ptt_id_mode = gBeamBackupVfo.DTMF_PTT_ID_TX_MODE;
+    payload->dtmf_ptt_id_mode = vfo->DTMF_PTT_ID_TX_MODE;
 #ifdef ENABLE_DTMF_CALLING
-    payload->dtmf_decoding_enable = gBeamBackupVfo.DTMF_DECODING_ENABLE;
+    payload->dtmf_decoding_enable = vfo->DTMF_DECODING_ENABLE;
 #endif
-    payload->step_setting = gBeamBackupVfo.STEP_SETTING;
+    payload->step_setting = vfo->STEP_SETTING;
-    payload->scrambling_type = gBeamBackupVfo.SCRAMBLING_TYPE;
+    payload->scrambling_type = vfo->SCRAMBLING_TYPE;
-    payload->band = gBeamBackupVfo.Band;
+    payload->band = vfo->Band;
-    payload->scanlist = gBeamBackupVfo.SCANLIST_PARTICIPATION;
+    payload->scanlist = vfo->SCANLIST_PARTICIPATION;
-    payload->compander = gBeamBackupVfo.Compander;
+    payload->compander = vfo->Compander;
 
-    BEAM_CopyNameFromActiveVfo(payload->name);
+    if (IS_MR_CHANNEL(vfo->CHANNEL_SAVE)) {
-}
+        SETTINGS_FetchChannelName(payload->name, vfo->CHANNEL_SAVE);
+    } else {
+        memcpy(payload->name, vfo->Name, sizeof(vfo->Name));
+    }
 
-static void BEAM_SendPacket(void)
-{
-    BEAM_Payload_t payload;
-
-    BEAM_FillPayload(&payload);
-
-    memset(g_FSK_Buffer, 0, sizeof(g_FSK_Buffer));
-    g_FSK_Buffer[0] = 0xABCDu;
-    memcpy(&g_FSK_Buffer[2], &payload, sizeof(payload));
     g_FSK_Buffer[34] = CRC_Calculate(&g_FSK_Buffer[1], 2 + 64);
     g_FSK_Buffer[35] = 0xDCBAu;
 
@@ -193,30 +154,23 @@ static void BEAM_SendPacket(void)
     gUpdateDisplay = true;
 }
 
-static uint16_t BEAM_FindFirstFreeChannel(void)
+static void BEAM_SavePayloadToFirstFreeChannel(const BEAM_Payload_t *payload)
 {
-    for (uint16_t channel = MR_CHANNEL_FIRST; IS_MR_CHANNEL(channel); channel++) {
+    uint16_t channel = 0xFFFFu;
-        if (!RADIO_CheckValidChannel(channel, false, 0))
+    
-            return channel;
+    for (uint16_t c = MR_CHANNEL_FIRST; IS_MR_CHANNEL(c); c++) {
+        if (!RADIO_CheckValidChannel(c, false, 0)) {
+            channel = c;
+            break;
+        }
     }
-
-    return 0xFFFFu;
-}
-
-static bool BEAM_SavePayloadToFirstFreeChannel(const BEAM_Payload_t *payload)
-{
-    uint16_t channel = BEAM_FindFirstFreeChannel();
-    char name[16];
 
     if (channel == 0xFFFFu) {
         gBeamStatus = BEAM_STATUS_RX_FULL;
         gUpdateDisplay = true;
-        return false;
+        return;
     }
 
-    memcpy(name, payload->name, sizeof(name));
-    name[sizeof(name) - 1] = 0;
-
     VFO_Info_t vfo;
     RADIO_InitInfo(&vfo, channel, payload->rx_frequency);
 
@@ -243,17 +197,21 @@ static bool BEAM_SavePayloadToFirstFreeChannel(const BEAM_Payload_t *payload)
     vfo.Band = payload->band;
     vfo.SCANLIST_PARTICIPATION = payload->scanlist;
     vfo.Compander = payload->compander;
-    memcpy(vfo.Name, name, sizeof(vfo.Name));
+    
+    memcpy(vfo.Name, payload->name, sizeof(vfo.Name));
+    vfo.Name[sizeof(vfo.Name) - 1] = '\0';
+    
     RADIO_ApplyOffset(&vfo);
     RADIO_ConfigureSquelchAndOutputPower(&vfo);
 
-    SETTINGS_SaveChannel(channel, gBeamVfoIndex, &vfo, 3);
+    SETTINGS_SaveChannel(channel, gEeprom.TX_VFO, &vfo, 3);
-    SETTINGS_SaveChannelName(channel, name);
+    SETTINGS_SaveChannelName(channel, vfo.Name);
 
     gBeamCopiedChannel = channel;
     gBeamStatus = BEAM_STATUS_RX_SAVED;
     gUpdateDisplay = true;
-    return true;
+    BACKLIGHT_TurnOn();
+    return;
 }
 
 static void BEAM_KeyMenu(void)
@@ -276,33 +234,26 @@ static void BEAM_KeyExit(void)
     BK4819_ResetFSK();
 
     if (gBeamMode == BEAM_MODE_RX && gBeamCopiedChannel != 0xFFFFu) {
-        gEeprom.MrChannel[gBeamVfoIndex] = gBeamCopiedChannel;
+        gEeprom.MrChannel[gEeprom.TX_VFO] = gBeamCopiedChannel;
-        gEeprom.ScreenChannel[gBeamVfoIndex] = gBeamCopiedChannel;
+        gEeprom.ScreenChannel[gEeprom.TX_VFO] = gBeamCopiedChannel;
-        RADIO_ConfigureChannel(gBeamVfoIndex, VFO_CONFIGURE_RELOAD);
+        RADIO_ConfigureChannel(gEeprom.TX_VFO, VFO_CONFIGURE_RELOAD);
-        RADIO_SelectVfos();
-        RADIO_SetupRegisters(true);
-        gBeamHasBackup = false;
-    } else {
-        BEAM_RestoreBackup();
     }
     
+    RADIO_SelectVfos();
+    RADIO_SetupRegisters(true);
+
     GUI_SelectNextDisplay(DISPLAY_MAIN);
-    gRequestDisplayScreen = DISPLAY_MAIN;
     gBeamActive = false;
-    gUpdateDisplay = true;
 }
 
 void ACTION_Beam(void)
 {
-    BEAM_SaveBackup();
     gBeamMode = BEAM_MODE_TX;
     gBeamStatus = BEAM_STATUS_READY;
     gBeamCopiedChannel = 0xFFFFu;
     gBeamRxWordCount = 0;
     gBeamActive = true;
     GUI_SelectNextDisplay(DISPLAY_MAIN);
-    gRequestDisplayScreen = DISPLAY_MAIN;
-    gUpdateDisplay = true;
 }
 
 void BEAM_ProcessKeys(KEY_Code_t Key, bool bKeyPressed, bool bKeyHeld)
@@ -316,7 +267,7 @@ void BEAM_ProcessKeys(KEY_Code_t Key, bool bKeyPressed, bool bKeyHeld)
     switch (Key) {
     case KEY_UP:
     case KEY_DOWN:
-        gBeamMode = (gBeamMode == BEAM_MODE_TX) ? BEAM_MODE_RX : BEAM_MODE_TX;
+        gBeamMode ^= 1; // (gBeamMode == BEAM_MODE_TX) ? BEAM_MODE_RX : BEAM_MODE_TX
         gBeamStatus = BEAM_STATUS_READY;
         gBeamRxWordCount = 0;
         break;
@@ -355,13 +306,12 @@ void BEAM_StorePacket(void)
     if (g_FSK_Buffer[34] != CRC_Calculate(&g_FSK_Buffer[1], 2 + 64))
         goto error;
 
-    BEAM_Payload_t payload;
+    BEAM_Payload_t * const payload = (BEAM_Payload_t *)&g_FSK_Buffer[2];
-    memcpy(&payload, &g_FSK_Buffer[2], sizeof(payload));
 
-    if (payload.magic != BEAM_PACKET_MAGIC || payload.version != BEAM_PACKET_VERSION)
+    if (payload->magic != BEAM_PACKET_MAGIC || payload->version != BEAM_PACKET_VERSION)
         goto error;
 
-    BEAM_SavePayloadToFirstFreeChannel(&payload);
+    BEAM_SavePayloadToFirstFreeChannel(payload);
     BK4819_ResetFSK();
     return;
 
@@ -369,6 +319,7 @@ error:
     gBeamStatus = BEAM_STATUS_ERROR;
     gBeamRxWordCount = 0;
     gUpdateDisplay = true;
+    BACKLIGHT_TurnOn();
 }
 
 #endif // ENABLE_FEAT_F4HWN_BEAM

App/app/main.c

@@ -262,19 +262,38 @@ static void processFKeyFunction(const KEY_Code_t Key, const bool beep)
             break;
 
         case KEY_7:
+#ifdef ENABLE_FEAT_F4HWN_GAME
+            if (!beep) {
+                APP_RunBreakout();
+            } else {
+#endif
 #ifdef ENABLE_VOX
                 ACTION_Vox();
 //#else
 //              toggle_chan_scanlist();
 #endif
+#ifdef ENABLE_FEAT_F4HWN_GAME
+            }
+#endif
+
             break;
 
         case KEY_8:
+            if (!beep) {
+                ACTION_BackLightOnDemand(); 
+            }
+            else {
                 gTxVfo->FrequencyReverse = gTxVfo->FrequencyReverse == false;
                 gRequestSaveChannel = 1;
+            }
+
             break;
 
         case KEY_9:
+            if (!beep) {
+                ACTION_BackLight();
+            }
+            else {
                 if (RADIO_CheckValidChannel(gEeprom.CHAN_1_CALL, false, 0)) {
                     gEeprom.MrChannel[Vfo]     = gEeprom.CHAN_1_CALL;
                     gEeprom.ScreenChannel[Vfo] = gEeprom.CHAN_1_CALL;
@@ -285,11 +304,9 @@ static void processFKeyFunction(const KEY_Code_t Key, const bool beep)
 #endif
                     gRequestSaveVFO            = true;
                     gVfoConfigureMode          = VFO_CONFIGURE_RELOAD;
-                break;
+                }
             }
 
-            if (beep)
-                gBeepToPlay = BEEP_500HZ_60MS_DOUBLE_BEEP_OPTIONAL;
             break;
 
 #ifdef ENABLE_FEAT_F4HWN // Set Squelch F + UP or Down and Step F + SIDE1 or F + SIDE2
@@ -655,30 +672,6 @@ static void MAIN_Key_DIGITS(KEY_Code_t Key, bool bKeyPressed, bool bKeyHeld)
 
     HideFKeyIcon();
 
-    #ifdef ENABLE_FEAT_F4HWN_RESCUE_OPS
-        if(gEeprom.MENU_LOCK == true && Key != 2) {
-            return;
-        }
-    #endif
-
-    if(Key == 8)
-    {
-        ACTION_BackLightOnDemand();
-        return;
-    }
-    else if(Key == 9)
-    {
-        ACTION_BackLight();
-        return;
-    }
-    #ifdef ENABLE_FEAT_F4HWN_GAME
-    else if(Key == 7)
-    {
-        APP_RunBreakout();
-        return;
-    }
-    #endif
-
     processFKeyFunction(Key, false);
 }
 

App/audio.c

@@ -41,7 +41,6 @@ static const uint16_t BEEP_Classic_array[][3] = { /* Tone    Duration    Repeats
     [BEEP_880HZ_200MS]                            = {880,    200,        1      },
     [BEEP_880HZ_500MS]                            = {880,    500,        1      },
 #endif
-    [BEEP_500HZ_60MS_DOUBLE_BEEP]                 = {500,    60,         2      },
 #ifdef ENABLE_FEAT_F4HWN
     [BEEP_400HZ_30MS]                             = {400,    30,         1      },
     [BEEP_500HZ_30MS]                             = {500,    30,         1      },

App/audio.h

@@ -38,7 +38,6 @@ enum BEEP_Type_t
     BEEP_880HZ_200MS,
     BEEP_880HZ_500MS,
 #endif
-    BEEP_500HZ_60MS_DOUBLE_BEEP,
 #ifdef ENABLE_FEAT_F4HWN
     BEEP_400HZ_30MS,
     BEEP_500HZ_30MS,

App/helper/battery.c

@@ -228,7 +228,7 @@ void BATTERY_TimeSlice500ms(void)
 
     if (lowBatteryCountdown < lowBatteryPeriod) {
         if (lowBatteryCountdown == lowBatteryPeriod-1 && !gChargingWithTypeC && !gLowBatteryConfirmed) {
-            AUDIO_PlayBeep(BEEP_500HZ_60MS_DOUBLE_BEEP);
+            AUDIO_PlayBeep(BEEP_500HZ_60MS_DOUBLE_BEEP_OPTIONAL);
         }
         return;
     }
@@ -241,7 +241,7 @@ void BATTERY_TimeSlice500ms(void)
 
     // not on charge
     if (!gLowBatteryConfirmed) {
-        AUDIO_PlayBeep(BEEP_500HZ_60MS_DOUBLE_BEEP);
+        AUDIO_PlayBeep(BEEP_500HZ_60MS_DOUBLE_BEEP_OPTIONAL);
 #ifdef ENABLE_VOICE
         AUDIO_SetVoiceID(0, VOICE_ID_LOW_VOLTAGE);
 #endif

App/ui/main.c

@@ -2100,9 +2100,10 @@ void UI_DisplayMain(void)
         else
 #endif
 #ifdef ENABLE_FEAT_F4HWN_SCAN_PROGRESS
-        if (!rx && gScanStateDir != SCAN_OFF && UI_DrawScanProgress())
+        if (!rx && gScanStateDir != SCAN_OFF && gKeypadLocked == 0)
         {
             center_line = CENTER_LINE_SCAN_PROGRESS;
+            UI_DrawScanProgress();
         }
         else
 #endif