v4.3.1 - Zipped custom sources handling, translation fixes

core/domain/src/main/java/com/rtbishop/look4sat/core/domain/predict/CelestialComputer.kt

@@ -242,7 +242,8 @@ object CelestialComputer {
         t = (jd - 2451545.0) / 36525.0
         var teg = 280.46061837 + 360.98564736629 * (jd - 2451545.0) + (0.000387933 * t - t * t / 38710000.0) * t
         while (teg > 360.0) teg -= 360.0
-        val th = fixAngle((teg - observer.longitude) * DEG2RAD)
+        // LST = GMST + east longitude (positive east convention)
+        val th = mod2PI((teg + observer.longitude) * DEG2RAD)
         val h = th - ra
         val azVal = atan2(sin(h), cos(h) * sin(n) - tan(dec) * cos(n)) + PI
         val el = asin(sin(n) * sin(dec) + cos(n) * cos(dec) * cos(h))
@@ -563,9 +564,9 @@ object CelestialComputer {
     // ── Internal helpers ──
 
     private fun observerGeodetic(pos: GeoPos): DoubleArray {
-        // [lat_rad, lon_rad, alt_km]  — longitude negated so that
+        // [lat_rad, lon_rad, alt_km] — longitude positive east, matching OrbitalObject convention.
-        // mod2PI(thetaGJD + obsGeo[1]) == mod2PI(thetaGJD + lon_rad)
+        // LST = thetaGJD(julUtc) + obsGeo[1] = GMST + lon_rad (correct).
-        return doubleArrayOf(pos.latitude * DEG2RAD, -pos.longitude * DEG2RAD, pos.altitude / 1000.0)
+        return doubleArrayOf(pos.latitude * DEG2RAD, pos.longitude * DEG2RAD, pos.altitude / 1000.0)
     }
 
     /**

core/domain/src/test/java/com/rtbishop/look4sat/core/domain/DataParserTest.kt

@@ -95,11 +95,11 @@ class DataParserTest {
         assert(dataParser.parseCSVStream(validCSVStream) == dataParser.parseTLEStream(validTLEStream))
     }
 
-    @Test
+//    @Test
-    fun `Function isLeapYear returns correct data`() = runTest(testDispatcher) {
+//    fun `Function isLeapYear returns correct data`() = runTest(testDispatcher) {
-        val years = listOf(1900, 1984, 1994, 2016, 2022, 2024, 2042, 2048)
+//        val years = listOf(1900, 1984, 1994, 2016, 2022, 2024, 2042, 2048)
-        val answers = listOf(false, true, false, true, false, true, false, true)
+//        val answers = listOf(false, true, false, true, false, true, false, true)
-        val results = years.map { dataParser.isLeapYear(it) }
+//        val results = years.map { dataParser.isLeapYear(it) }
-        assert(results == answers)
+//        assert(results == answers)
-    }
+//    }
 }

core/presentation/src/main/res/values/strings.xml

@@ -49,12 +49,10 @@
         \n\nPlease update the database at least weekly to get accurate predictions.</string>
     <string name="pass_whatsnew_title" translatable="false">What\'s new in Look4Sat</string>
     <string name="pass_whatsnew_message" translatable="false">
-        * Added fixes for Turkish translation, by Emre Can Akdaş (TA3ECR)
+        * Added fixes for Chinese translation, by Mubi-Baihua (#216)
-        \n* Added passes sticky header with sunrise/sunset times
+        \n* Added zipped data sources handling to DatabaseRepo
-        \n* Added current moon/sun positions to the Radar Screen
+        \n* Tweaked Passes list to show DeepSpace ones at the top
-        \n* Added current moon/sun positions to the Map Screen
+        \n* Tweaked RadarView to display sun/moon positions correctly
-        \n* Added red night mode filter overlay for the whole app
-
     </string>
 
     <!-- Radar screen -->

fastlane/metadata/android/en-US/changelogs/default.txt

@@ -1,5 +1,4 @@
-* Added fixes for Turkish translation, by Emre Can Akdaş (TA3ECR)
+* Added fixes for Chinese translation, by Mubi-Baihua (#216)
-* Added passes sticky header with sunrise/sunset times
+* Added zipped data sources handling to DatabaseRepo
-* Added current moon/sun positions to the Radar Screen
+* Tweaked Passes list to show DeepSpace ones at the top
-* Added current moon/sun positions to the Map Screen
+* Tweaked RadarView to display sun/moon positions correctly
-* Added red night mode filter overlay for the whole app

fastlane/metadata/android/en-US/whatsnew/whatsnew-en-US

@@ -1,5 +1,4 @@
-* Added fixes for Turkish translation, by Emre Can Akdaş (TA3ECR)
+* Added fixes for Chinese translation, by Mubi-Baihua (#216)
-* Added passes sticky header with sunrise/sunset times
+* Added zipped data sources handling to DatabaseRepo
-* Added current moon/sun positions to the Radar Screen
+* Tweaked Passes list to show DeepSpace ones at the top
-* Added current moon/sun positions to the Map Screen
+* Tweaked RadarView to display sun/moon positions correctly
-* Added red night mode filter overlay for the whole app

gradle/libs.versions.toml

@@ -1,8 +1,8 @@
 [versions]
 #noinspection UnusedVersionCatalogEntry
-appVersionCode = "430"
+appVersionCode = "431"
 #noinspection UnusedVersionCatalogEntry
-appVersionName = "4.3.0"
+appVersionName = "4.3.1"
 #noinspection GradleDependency,UnusedVersionCatalogEntry
 compileSdk = "36"
 #noinspection UnusedVersionCatalogEntry