v4.4.4 - Icom CAT, components, filters and sources tweaks

2026-10-02 03:15:37 +00:00 · 2026-08-04 20:51:22 +02:00
1 parent bd0881fb4b
commit 602b1553a2
@@ -37,6 +37,7 @@ import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.update
 import kotlinx.coroutines.withContext
 import java.util.TimeZone
+import kotlin.time.Duration.Companion.milliseconds

 class SatelliteRepo(
    private val dispatcher: CoroutineDispatcher,
@@ -158,7 +159,7 @@ class SatelliteRepo(
                }
            }
            newPasses.sortBy { it.aosTime }
-            delay(1000) // Simulate loading time for better UX
+            delay(1000.milliseconds) // Simulate loading time for better UX
            _passes.update { newPasses }
        }
        _isCalculating.value = false
@@ -176,7 +177,7 @@ class SatelliteRepo(
        val inRange = if (aosStartMinute <= aosEndMinute) {
            aosMinute in aosStartMinute..aosEndMinute
        } else {
-            aosMinute >= aosStartMinute || aosMinute <= aosEndMinute
+            aosMinute !in (aosEndMinute + 1)..<aosStartMinute
        }
        return if (invertAosTimeWindow) !inRange else inRange
    }
@@ -38,16 +38,16 @@ class SelectionRepo(
 ) : ISelectionRepo {

    private val currentItems = MutableStateFlow<List<SatItem>>(emptyList())
-    private val currentModes = MutableStateFlow(settingsRepo.selectedSatModes.value)
    private val currentQuery = MutableStateFlow("")

    // Resolve sat IDs once when modes change, then filter items reactively.
    // The HashSet gives O(1) catnum lookups instead of O(n) with a List.
-    private val itemsWithModes = currentModes.flatMapLatest { modes: List<String> ->
-        val catnumSet: Set<Int>? = if (modes.isEmpty()) {
+    // Directly observe settingsRepo.selectedSatModes to ensure real-time sync across screens.
+    private val itemsWithModes = settingsRepo.selectedSatModes.flatMapLatest { list: List<String> ->
+        val catnumSet: Set<Int>? = if (list.isEmpty()) {
            null // null = no filtering
        } else {
-            val ids = localSource.getIdsWithModes(modes)
+            val ids = localSource.getIdsWithModes(list)
            if (ids.isEmpty()) null else ids.toHashSet()
        }
        currentItems.map { items ->
@@ -65,7 +65,7 @@ class SelectionRepo(
        }
    }

-    override fun getCurrentModes() = currentModes.value
+    override fun getCurrentModes() = settingsRepo.selectedSatModes.value

    override fun getModesList() = Sources.satelliteModes

@@ -78,7 +78,6 @@ class SelectionRepo(
    }

    override suspend fun setModes(modes: List<String>) {
-        currentModes.value = modes
        settingsRepo.setSelectedSatModes(modes)
    }

@@ -24,7 +24,6 @@ import kotlinx.coroutines.CoroutineDispatcher
 import kotlinx.coroutines.withContext
 import okhttp3.OkHttpClient
 import okhttp3.Request
-import java.io.ByteArrayInputStream
 import java.io.InputStream

 class RemoteSource(
@@ -46,10 +45,14 @@ class RemoteSource(
    override suspend fun getNetworkStream(url: String): InputStream? = withContext(dispatcher) {
        try {
            val networkRequest = Request.Builder().url(url).build()
-            httpClient.newCall(networkRequest).execute().use { response ->
-                if (!response.isSuccessful) return@withContext null
-                ByteArrayInputStream(response.body.bytes())
+            val response = httpClient.newCall(networkRequest).execute()
+            if (!response.isSuccessful) {
+                response.close()
+                return@withContext null
            }
+            // Return the body stream directly as the caller is responsible for closing it
+            // That returns the connection to OkHttp's pool
+            response.body.byteStream().buffered()
        } catch (exception: Exception) {
            println("RemoteSource network stream exception: $exception")
            null
@@ -19,10 +19,10 @@ package com.rtbishop.look4sat.core.domain.source

 object Sources {
    val satelliteDataUrls = mapOf(
-        "All" to "https://celestrak.org/NORAD/elements/gp.php?GROUP=active&FORMAT=csv",
-        "Amsat" to "https://amsat.org/tle/current/nasabare.txt",
-        "Classified" to "https://www.mmccants.org/tles/classfd.zip",
-        "McCants" to "https://www.mmccants.org/tles/inttles.zip",
+        "CelesTrak" to "https://celestrak.org/NORAD/elements/gp.php?GROUP=active&FORMAT=csv",
+        "AMSAT" to "https://amsat.org/tle/current/nasabare.txt",
+        "McCants Classified" to "https://www.mmccants.org/tles/classfd.zip",
+        "McCants Integrated" to "https://www.mmccants.org/tles/inttles.zip",
        "R4UAB" to "https://r4uab.ru/satonline.txt",
        "SatNOGS" to "https://db.satnogs.org/api/tle/?format=3le",
        "ARISS" to "https://live.ariss.org/iss.txt",
@@ -91,7 +91,7 @@ class DataParser(private val dispatcher: CoroutineDispatcher) {
        val line1 = tle[1]
        val line2 = tle[2]
        OrbitalData(
-            name = tle[0].trim(),
+            name = tle[0].trim().removePrefix("0 "),
            epoch = line1.substring(18, 32).toDouble(),
            meanmo = line2.substring(52, 63).toDouble(),
            eccn = line2.substring(26, 33).toDouble() / 1e7,
@@ -47,6 +47,7 @@ import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.ModalBottomSheet
 import androidx.compose.material3.Surface
 import androidx.compose.material3.Text
+import androidx.compose.material3.SheetValue
 import androidx.compose.material3.rememberModalBottomSheetState
 import androidx.compose.material3.adaptive.currentWindowAdaptiveInfo
 import androidx.compose.runtime.Composable
@@ -308,7 +309,8 @@ fun SharedDialog(
    titleTextAlign: TextAlign = if (onCancel != null && onAccept != null) TextAlign.Center else TextAlign.Start,
    content: @Composable (padding: Dp) -> Unit
 ) {
-    DialogShell(onDismissRequest = onDismissRequest) { padding ->
+    val dismissible = onCancel != null
+    DialogShell(onDismissRequest = onDismissRequest, dismissible = dismissible) { padding ->
        Row(
            verticalAlignment = Alignment.CenterVertically,
            modifier = Modifier
@@ -342,10 +344,14 @@ fun SharedDialog(
@Composable
 private fun DialogShell(
    onDismissRequest: () -> Unit,
+    dismissible: Boolean = true,
    content: @Composable (padding: Dp) -> Unit
 ) {
    val padding = LocalSpacing.current.large
-    val sheetState = rememberModalBottomSheetState(skipPartiallyExpanded = true)
+    val sheetState = rememberModalBottomSheetState(
+        skipPartiallyExpanded = true,
+        confirmValueChange = { if (dismissible) true else it != SheetValue.Hidden }
+    )
    val stopSheetFling = remember {
        object : NestedScrollConnection {
            override suspend fun onPostFling(consumed: Velocity, available: Velocity): Velocity {
@@ -360,7 +366,7 @@ private fun DialogShell(
        }
    }
    ModalBottomSheet(
-        onDismissRequest = onDismissRequest,
+        onDismissRequest = if (dismissible) onDismissRequest else { {} },
        sheetState = sheetState,
        dragHandle = null,
        shape = RoundedCornerShape(topStart = 24.dp, topEnd = 24.dp),
@@ -0,0 +1,9 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:viewportWidth="15"
+    android:viewportHeight="15">
+    <path
+        android:fillColor="@android:color/white"
+        android:pathData="M13.91,6.75c-1.17,2.25 -4.3,5.31 -6.07,6.94c-0.19,0.172 -0.48,0.172 -0.67,0C5.39,12.06 2.26,9 1.09,6.75C-1.48,1.8 5,-1.5 7.5,3.45C10,-1.5 16.48,1.8 13.91,6.75z" />
+</vector>
@@ -1,9 +0,0 @@
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="24dp"
-    android:height="24dp"
-    android:viewportWidth="24"
-    android:viewportHeight="24">
-    <path
-        android:fillColor="@android:color/white"
-        android:pathData="M14,21c1.93,0 3.62,-1.17 4,-3l-1.75,-0.88C16,18.21 15.33,19 14,19l-4.9,0c0.83,-1 1.5,-2.34 1.5,-4c0,-0.35 -0.03,-0.69 -0.08,-1L14,14v-2l-4.18,0C9,10.42 8,9.6 8,8c0,-1.93 1.57,-3.5 3.5,-3.5c1.5,0 2.79,0.95 3.28,2.28L16.63,6c-0.8,-2.05 -2.79,-3.5 -5.13,-3.5C8.46,2.5 6,4.96 6,8c0,1.78 0.79,2.9 1.49,4L6,12v2l2.47,0c0.08,0.31 0.13,0.64 0.13,1c0,2.7 -2.6,4 -2.6,4v2H14z" />
-</vector>
@@ -1,9 +0,0 @@
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="24dp"
-    android:height="24dp"
-    android:viewportWidth="960"
-    android:viewportHeight="960">
-    <path
-        android:fillColor="@android:color/white"
-        android:pathData="M240,800L280,640L120,640L140,560L300,560L340,400L180,400L200,320L360,320L400,160L480,160L440,320L600,320L640,160L720,160L680,320L840,320L820,400L660,400L620,560L780,560L760,640L600,640L560,800L480,800L520,640L360,640L320,800L240,800ZM380,560L540,560L580,400L420,400L380,560Z" />
-</vector>
@@ -155,11 +155,11 @@
    <string name="prefs_net_perm_error">Revisa los permisos de red</string>

    <string name="prefs_other_title">Otros</string>
-    <string name="prefs_other_switch_utc">Mostrar hora UTC</string>
+    <string name="prefs_other_switch_utc">Hora UTC</string>
    <string name="prefs_other_switch_update">Actualización automática</string>
-    <string name="prefs_other_switch_sweep">Animación de radar</string>
-    <string name="prefs_other_switch_sensors">Sensores para radar</string>
-    <string name="prefs_other_switch_night_mode">Filtro nocturno rojo</string>
+    <string name="prefs_other_switch_sweep">Animación radar</string>
+    <string name="prefs_other_switch_sensors">Sensores</string>
+    <string name="prefs_other_switch_night_mode">Filtro nocturno</string>

    <string name="prefs_highlight_title">Resaltado de elevación</string>
    <string name="prefs_highlight_low">Baja &lt; %1$d°</string>
@@ -158,8 +158,8 @@
    <string name="prefs_other_switch_utc">Время в UTC</string>
    <string name="prefs_other_switch_update">Автообновление данных</string>
    <string name="prefs_other_switch_sweep">Анимация радара</string>
-    <string name="prefs_other_switch_sensors">Сенсоры для радара</string>
-    <string name="prefs_other_switch_night_mode">Красный ночной фильтр</string>
+    <string name="prefs_other_switch_sensors">Сенсоры</string>
+    <string name="prefs_other_switch_night_mode">Ночной фильтр</string>

    <string name="prefs_highlight_title">Подсветка высоты</string>
    <string name="prefs_highlight_low">Низко &lt; %1$d°</string>
@@ -155,11 +155,11 @@
    <string name="prefs_net_perm_error">Network අවසර පරික්‍ෂා කරන්න</string>

    <string name="prefs_other_title">වෙනත්</string>
-    <string name="prefs_other_switch_utc">UTC වේලාව පෙන්වන්න</string>
+    <string name="prefs_other_switch_utc">UTC වේලාව</string>
    <string name="prefs_other_switch_update">දත්ත ස්වයං යාවත්කාලීන</string>
-    <string name="prefs_other_switch_sweep">Radar sweep සජීවිකරණය</string>
-    <string name="prefs_other_switch_sensors">Radar සඳහා සංවේදක භාවිතා කරන්න</string>
-    <string name="prefs_other_switch_night_mode">රතු රාත්‍රී පෙරහන</string>
+    <string name="prefs_other_switch_sweep">Radar sweep</string>
+    <string name="prefs_other_switch_sensors">සංවේදක</string>
+    <string name="prefs_other_switch_night_mode">රාත්‍රී පෙරහන</string>

    <string name="prefs_highlight_title">උස් උද්දීපනය</string>
    <string name="prefs_highlight_low">අඩු &lt; %1$d°</string>
@@ -187,11 +187,11 @@
    <string name="prefs_net_perm_error">Ağ izninizi kontrol edin</string>

    <string name="prefs_other_title">Diğer</string>
-    <string name="prefs_other_switch_utc">UTC saatini göster</string>
+    <string name="prefs_other_switch_utc">UTC saati</string>
    <string name="prefs_other_switch_update">Veriyi otomatik güncelle</string>
-    <string name="prefs_other_switch_sweep">Radar tarama animasyonu</string>
-    <string name="prefs_other_switch_sensors">Radar için sensör kullan</string>
-    <string name="prefs_other_switch_night_mode">Kırmızı gece filtresi</string>
+    <string name="prefs_other_switch_sweep">Radar taraması</string>
+    <string name="prefs_other_switch_sensors">Sensör</string>
+    <string name="prefs_other_switch_night_mode">Gece filtresi</string>

    <string name="prefs_highlight_title">Elevasyon vurgusu</string>
    <string name="prefs_highlight_low">Düşük &lt; %1$d°</string>
@@ -158,8 +158,8 @@
    <string name="prefs_other_switch_utc">Час в UTC</string>
    <string name="prefs_other_switch_update">Автооновлення даних</string>
    <string name="prefs_other_switch_sweep">Анімація радара</string>
-    <string name="prefs_other_switch_sensors">Сенсори для радара</string>
-    <string name="prefs_other_switch_night_mode">Червоний нічний фільтр</string>
+    <string name="prefs_other_switch_sensors">Сенсори</string>
+    <string name="prefs_other_switch_night_mode">Нічний фільтр</string>

    <string name="prefs_highlight_title">Підсвічування висоти</string>
    <string name="prefs_highlight_low">Низько &lt; %1$d°</string>
@@ -55,8 +55,16 @@
        \n\nPlease update the database at least weekly to get accurate predictions.</string>
    <string name="pass_whatsnew_title" translatable="false">What\'s new in Look4Sat</string>
    <string name="pass_whatsnew_message" translatable="false">
-        * Added required tweaks to support Android 17 (API 37)
-        \n\n* Added ACCESS_LOCAL_NETWORK permission check to support network data output
+        * Added small tweaks to Sources and strings. Added official ISS source (#225)
+        \n* Implemented AOS window and elevation highlight filters (#226)
+        \n* Added cleartext traffic support for custom TLE URLs (#227)
+        \n* Fixed manual OMM (.csv) data import, tweaked error messaging (#228)
+        \n* Added support for Icom IC-705 CAT by ruilvo (#229)
+        \n* Added configurable Radar offset to the sensors output by qwqtoday (#230)
+        \n* Localized pass date and time formats for Chinese by atsunatsu (#231)
+        \n* Added linear transponder Doppler calculator by atsunatsu (#232)
+        \n* Added a few tweaks to SSTV sensitivity and reception, similar to Robot36
+        \n* Replaced the types selection dialog with modes selection to avoid confusion
    </string>

    <!-- Radar screen -->
@@ -187,11 +195,11 @@
    <string name="prefs_net_perm_error">Check your network permission</string>

    <string name="prefs_other_title">Other</string>
-    <string name="prefs_other_switch_utc">Show UTC time</string>
+    <string name="prefs_other_switch_utc">UTC time</string>
    <string name="prefs_other_switch_update">Auto-update data</string>
-    <string name="prefs_other_switch_sweep">Radar sweep animation</string>
-    <string name="prefs_other_switch_sensors">Use sensors for radar</string>
-    <string name="prefs_other_switch_night_mode">Red night filter</string>
+    <string name="prefs_other_switch_sweep">Radar sweep</string>
+    <string name="prefs_other_switch_sensors">Use sensors</string>
+    <string name="prefs_other_switch_night_mode">Night filter</string>
    <string name="prefs_other_compass_offset">Radar compass offset</string>
    <string name="prefs_other_compass_offset_elev">Radar compass offset (elev)</string>