mckero
321cd8f2fa
An auditor ran the plan's own release gate against live APRS-IS servers. It failed at
the login step, on every server tried:
sent: user N0CALL pass -1 vers Look4Sat-4.5.4
got: # Invalid login: software name and version are not separated by a space
Reproduced on euro.aprs2.net and noam.aprs2.net, aprsc 2.1.21. `vers` takes TWO tokens,
a software name and a version. An earlier commit read the rule "softwarename must not
contain a space" as "the field must be one token" and hyphenated the space between them
- and the unit test asserted that as correct, so the mistake was frozen in place.
Worse than the malformed line was what happened next. `# Invalid login:` is a comment
but not a logresp, so parse skipped it as keepalive chatter; the login then timed out
into Unknown, which is deliberately treated as "may be working"; so `ok = sent &&
!refused` was true and the operator was shown "APRS: report sent OK" for a login the
server had refused. That is v4.6.0's defining defect - every send reported successful
regardless of outcome - still live on the exact path every operator takes. The rebuild
narrowed it rather than closing it.
Both halves are fixed: the name and version stay separate tokens with whitespace
collapsed within each, and a refusal comment is classified as a refusal before the
logresp test. A socket test now replays the server's actual bytes.
Three smaller things from the same review:
The foreground service type goes back to dataSync. The previous commit chose location
to escape dataSync's six-hour cap, but a location-typed service is refused outright
unless a location runtime permission has already been granted, and the settings card
requests only notifications - so it would have failed silently for anyone who declined
location access. The cap that prompted the switch applies only when targetSdk is 35 or
higher, which this project does not declare. A test now reads the manifest and the
service source and fails if they disagree, which is the only way this class of defect
is visible from a JVM test.
The version string in the login was 4.5.4 while the app was 4.6.0. Now split into name
and version and corrected, though it is still hardcoded - core:data has no BuildConfig,
so passing it in properly is a separate change.
The passcode hint said "empty = auto-computed from callsign" in all five locales. The
app stopped doing that two commits ago; it now connects receive-only, and the hint says
so. It was the first thing an operator read next to the field, promising the behaviour
that was deliberately removed.
Not fixed, and known: the notification body is rebuilt from the previous cycle's state
so it can show a stale verdict, a deliberate receive-only choice is still styled as an
error, and no last-success timestamp exists - so an operator still cannot establish
whether their station has ever reached the network.
72 lines
3.7 KiB
XML
72 lines
3.7 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
|
|
|
|
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
|
|
<uses-permission android:name="android.permission.ACCESS_LOCAL_NETWORK" />
|
|
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
|
|
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
|
|
<uses-permission
|
|
android:name="android.permission.BLUETOOTH"
|
|
android:maxSdkVersion="30" />
|
|
<uses-permission android:name="android.permission.BLUETOOTH_ADMIN" />
|
|
<uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
|
|
<uses-permission android:name="android.permission.BLUETOOTH_SCAN" />
|
|
<uses-permission android:name="android.permission.INTERNET" />
|
|
<uses-permission android:name="android.permission.RECORD_AUDIO" />
|
|
|
|
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
|
|
<!--
|
|
dataSync rather than location. The location type is refused outright unless a location
|
|
runtime permission has already been granted - startForeground throws SecurityException -
|
|
and this service reads the station position the operator typed into settings, so demanding
|
|
location access to beacon a fixed QTH is both wrong and a way to fail silently for anyone
|
|
who declined it. The dataSync six-hour cap that prompted the earlier switch applies only
|
|
when targetSdk is 35 or higher, which this project does not declare.
|
|
-->
|
|
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_DATA_SYNC" />
|
|
<!--
|
|
Doze suspends network access and ignores wake locks even for a foreground service, so a
|
|
coroutine delay wakes up on time and then cannot reach the network. An exact alarm with
|
|
setExactAndAllowWhileIdle is the only scheduling that survives Doze, and at a five-minute
|
|
floor the system's one-alarm-per-nine-minutes throttle is not a problem.
|
|
-->
|
|
<uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" />
|
|
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
|
|
<application
|
|
android:name=".MainApplication"
|
|
android:allowBackup="false"
|
|
android:icon="@mipmap/ic_launcher"
|
|
android:label="@string/app_name"
|
|
android:networkSecurityConfig="@xml/network_security_config"
|
|
android:roundIcon="@mipmap/ic_launcher_round">
|
|
|
|
<activity
|
|
android:name=".MainActivity"
|
|
android:exported="true"
|
|
android:screenOrientation="portrait"
|
|
android:theme="@style/Theme.Look4Sat.SplashScreen">
|
|
<intent-filter>
|
|
<action android:name="android.intent.action.MAIN" />
|
|
<category android:name="android.intent.category.LAUNCHER" />
|
|
</intent-filter>
|
|
<!-- <intent-filter android:autoVerify="true">-->
|
|
<!-- <action android:name="android.intent.action.VIEW" />-->
|
|
<!-- <category android:name="android.intent.category.DEFAULT" />-->
|
|
<!-- <category android:name="android.intent.category.BROWSABLE" />-->
|
|
<!-- <data android:scheme="https" />-->
|
|
<!-- <data android:host="github.com" />-->
|
|
<!-- <data android:pathPattern="/rt-bishop/Look4Sat/passes.*" />-->
|
|
<!-- </intent-filter>-->
|
|
</activity>
|
|
|
|
<meta-data
|
|
android:name="android.telephony.PROPERTY_SATELLITE_DATA_OPTIMIZED"
|
|
android:value="com.rtbishop.look4sat.bg7nta" />
|
|
|
|
<service
|
|
android:name="com.rtbishop.look4sat.app.AprsForegroundService"
|
|
android:exported="false"
|
|
android:foregroundServiceType="dataSync" />
|
|
</application>
|
|
</manifest>
|