Using action navigating to sources dialog, removed unnecessary scopes

This commit is contained in:
Arty Bishop committed 2020-10-25 20:07:11 +00:00
1 parent a7eb805f6d
commit cfdba41ed5
6 files changed
+37 -55

No files matched your search

@@ -24,24 +24,21 @@ import dagger.Module
import dagger.Provides import dagger.Provides
import dagger.hilt.InstallIn import dagger.hilt.InstallIn
import dagger.hilt.android.components.ActivityComponent import dagger.hilt.android.components.ActivityComponent
import dagger.hilt.android.scopes.ActivityScoped
import okhttp3.OkHttpClient import okhttp3.OkHttpClient
import retrofit2.Retrofit import retrofit2.Retrofit
import retrofit2.converter.moshi.MoshiConverterFactory import retrofit2.converter.moshi.MoshiConverterFactory
@Module @Module
@InstallIn(ActivityComponent::class) @InstallIn(ActivityComponent::class)
class NetworkModule { object NetworkModule {
@ActivityScoped
@Provides @Provides
fun provideWebClient(): OkHttpClient { fun getOkHttpClient(): OkHttpClient {
return OkHttpClient() return OkHttpClient()
} }
@ActivityScoped
@Provides @Provides
fun provideTransApi(): TransmittersApi { fun getTransmittersApi(): TransmittersApi {
return Retrofit.Builder() return Retrofit.Builder()
.baseUrl("https://db.satnogs.org/api/") .baseUrl("https://db.satnogs.org/api/")
.addConverterFactory(MoshiConverterFactory.create()) .addConverterFactory(MoshiConverterFactory.create())
@@ -30,33 +30,28 @@ import dagger.Provides
import dagger.hilt.InstallIn import dagger.hilt.InstallIn
import dagger.hilt.android.components.ActivityComponent import dagger.hilt.android.components.ActivityComponent
import dagger.hilt.android.qualifiers.ActivityContext import dagger.hilt.android.qualifiers.ActivityContext
import dagger.hilt.android.scopes.ActivityScoped
@Module @Module
@InstallIn(ActivityComponent::class) @InstallIn(ActivityComponent::class)
class PersistenceModule { object PersistenceModule {
@ActivityScoped
@Provides @Provides
fun provideEntriesDao(db: SatelliteDb): EntriesDao { fun getEntriesDao(db: SatelliteDb): EntriesDao {
return db.entriesDao() return db.entriesDao()
} }
@ActivityScoped
@Provides @Provides
fun provideTransDao(db: SatelliteDb): TransmittersDao { fun getSourcesDao(db: SatelliteDb): SourcesDao {
return db.transmittersDao()
}
@ActivityScoped
@Provides
fun providesSourcesDao(db: SatelliteDb): SourcesDao {
return db.sourcesDao() return db.sourcesDao()
} }
@ActivityScoped
@Provides @Provides
fun provideSatDb(@ActivityContext context: Context): SatelliteDb { fun getTransmittersDao(db: SatelliteDb): TransmittersDao {
return db.transmittersDao()
}
@Provides
fun getSatelliteDb(@ActivityContext context: Context): SatelliteDb {
return Room.databaseBuilder(context, SatelliteDb::class.java, "satDb").build() return Room.databaseBuilder(context, SatelliteDb::class.java, "satDb").build()
} }
} }
@@ -31,41 +31,31 @@ import dagger.Provides
import dagger.hilt.InstallIn import dagger.hilt.InstallIn
import dagger.hilt.android.components.ActivityComponent import dagger.hilt.android.components.ActivityComponent
import dagger.hilt.android.qualifiers.ActivityContext import dagger.hilt.android.qualifiers.ActivityContext
import dagger.hilt.android.scopes.ActivityScoped
import okhttp3.OkHttpClient import okhttp3.OkHttpClient
@Module @Module
@InstallIn(ActivityComponent::class) @InstallIn(ActivityComponent::class)
class RepoModule { object RepoModule {
@ActivityScoped
@Provides @Provides
fun provideContentResolver(@ActivityContext context: Context): ContentResolver { fun getEntriesRepo(resolver: ContentResolver, client: OkHttpClient, entriesDao: EntriesDao)
return context.applicationContext.contentResolver : EntriesRepo {
}
@ActivityScoped
@Provides
fun provideEntriesRepo(
resolver: ContentResolver,
client: OkHttpClient,
entriesDao: EntriesDao
): EntriesRepo {
return DefaultEntriesRepo(resolver, client, entriesDao) return DefaultEntriesRepo(resolver, client, entriesDao)
} }
@ActivityScoped
@Provides @Provides
fun provideSourcesRepo(sourcesDao: SourcesDao): SourcesRepo { fun getSourcesRepo(sourcesDao: SourcesDao): SourcesRepo {
return DefaultSourcesRepo(sourcesDao) return DefaultSourcesRepo(sourcesDao)
} }
@ActivityScoped
@Provides @Provides
fun provideTransmittersRepo( fun getTransmittersRepo(transDao: TransmittersDao, transApi: TransmittersApi)
transmittersDao: TransmittersDao, : TransmittersRepo {
transmittersApi: TransmittersApi return DefaultTransmittersRepo(transDao, transApi)
): TransmittersRepo { }
return DefaultTransmittersRepo(transmittersDao, transmittersApi)
@Provides
fun getContentResolver(@ActivityContext context: Context): ContentResolver {
return context.applicationContext.contentResolver
} }
} }
@@ -29,30 +29,23 @@ import dagger.Provides
import dagger.hilt.InstallIn import dagger.hilt.InstallIn
import dagger.hilt.android.components.ActivityComponent import dagger.hilt.android.components.ActivityComponent
import dagger.hilt.android.qualifiers.ActivityContext import dagger.hilt.android.qualifiers.ActivityContext
import dagger.hilt.android.scopes.ActivityScoped
@Module @Module
@InstallIn(ActivityComponent::class) @InstallIn(ActivityComponent::class)
class UtilityModule { object UtilityModule {
@ActivityScoped
@Provides @Provides
fun provideSharedPreferences(@ActivityContext context: Context): SharedPreferences { fun getSharedPreferences(@ActivityContext context: Context): SharedPreferences {
return PreferenceManager.getDefaultSharedPreferences(context) return PreferenceManager.getDefaultSharedPreferences(context)
} }
@ActivityScoped
@Provides @Provides
fun provideLocationManager(@ActivityContext context: Context): LocationManager { fun getLocationManager(@ActivityContext context: Context): LocationManager {
return context.getSystemService(Context.LOCATION_SERVICE) as LocationManager return context.getSystemService(Context.LOCATION_SERVICE) as LocationManager
} }
@ActivityScoped
@Provides @Provides
fun providePrefsManager( fun getPrefsManager(prefs: SharedPreferences, locationManager: LocationManager): PrefsManager {
sharedPreferences: SharedPreferences, return PrefsManager(prefs, locationManager)
locationManager: LocationManager
): PrefsManager {
return PrefsManager(sharedPreferences, locationManager)
} }
} }
@@ -76,7 +76,7 @@ class EntriesFragment : Fragment(R.layout.fragment_entries) {
} }
private fun showImportFromWebDialog() { private fun showImportFromWebDialog() {
findNavController().navigate(R.id.nav_dialog_sources) findNavController().navigate(R.id.action_entries_to_dialog_sources)
} }
private fun showImportFromFileDialog() { private fun showImportFromFileDialog() {
@@ -34,6 +34,13 @@
app:exitAnim="@anim/nav_default_exit_anim" app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim" app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" /> app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_entries_to_dialog_sources"
app:destination="@id/nav_dialog_sources"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
</fragment> </fragment>
<fragment <fragment