fix(sources): a dead custom URL no longer counts as a successful update
Found by an audit of the replace-semantics commit rather than by the change itself. The success count added orbital and transceivers sources together, so one could stand in for the other. With the built-in sources replaced there are two requests instead of 28: if the operator's TLE URL was down and SatNOGS answered, the count was 1, no exception was raised, and setUpdateSuccessful stamped a fresh timestamp for an update that refreshed no orbital elements at all. That also suppressed the 48-hour auto-update retry, which keys off that timestamp - so the operator was left with stale orbits, a screen saying the update worked, and nothing scheduled to correct it. The failure existed before this rebuild, but 26 other sources masked it. Narrowing the source set made it easy to hit, which is why it belongs with these commits rather than in a backlog. Orbital sources are now counted on their own. A test covers the exact case: transceivers answers, the custom TLE URL does not, and the update must raise rather than record success. Also: an upload that found nothing waiting said "Uploaded 0 QSO". Accurate, but it reads oddly when the queue was already clear, so that case has its own wording now.
This commit is contained in:
1 parent
cd70e3654c
commit
6db10b5b72
5 files changed
+49
-4
No files matched your search
@@ -263,6 +263,7 @@
|
||||
<string name="wavelog_saved">已存入本地日志</string>
|
||||
<string name="wavelog_upload_done">已上传 %1$d 条, %2$d 条仍在队列</string>
|
||||
<string name="wavelog_upload_all_ok">已上传 %1$d 条</string>
|
||||
<string name="wavelog_nothing_to_upload">没有待上传的联络</string>
|
||||
<string name="wavelog_not_configured">未配置 WaveLog 服务器</string>
|
||||
<string name="wavelog_no_station">读不到站点信息 - 请检查站点 ID 与密钥权限</string>
|
||||
<string name="wavelog_upload_failed">上传失败</string>
|
||||
|
||||
@@ -294,6 +294,7 @@
|
||||
<string name="wavelog_saved">Saved to local log</string>
|
||||
<string name="wavelog_upload_done">Uploaded %1$d, %2$d still queued</string>
|
||||
<string name="wavelog_upload_all_ok">Uploaded %1$d QSO</string>
|
||||
<string name="wavelog_nothing_to_upload">Nothing waiting to upload</string>
|
||||
<string name="wavelog_not_configured">WaveLog server not configured</string>
|
||||
<string name="wavelog_no_station">Cannot read the station profile - check the station ID and key permissions</string>
|
||||
<string name="wavelog_upload_failed">Upload failed</string>
|
||||
|
||||
Reference in new issue
Block a user