From 6636dd8e985f24dd49c7a4ff3d8fa9022965baa8 Mon Sep 17 00:00:00 2001 From: QIU Date: Tue, 4 Aug 2026 00:52:43 +0000 Subject: [PATCH] fix(settings): crash when scrolling Settings (nested LazyColumn unbounded height) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit v4.4.9 page-order list crashed the Settings screen on scroll: the drag-reorder LazyColumn sits inside the Settings LazyVerticalGrid item, and a vertically scrollable child measured with infinite max height throws IllegalStateException, killing the app before the UI Settings card even renders. Fix: give the LazyColumn a bounded height (itemHeight * items.size = 7 rows × 48dp = 336dp). Drag logic, animation and persistence unchanged. What's-new rewritten in en/zh/tr with ONLY this fix (user rule: replace, never append history). Version stays 4.4.9 (覆盖 per user). Verified: settings + app compile; check_strings.py clean. --- .../presentation/src/main/res/values-tr/strings.xml | 11 +---------- .../presentation/src/main/res/values-zh/strings.xml | 13 ++----------- core/presentation/src/main/res/values/strings.xml | 11 +---------- .../look4sat/feature/settings/SettingsScreen.kt | 8 +++++++- 4 files changed, 11 insertions(+), 32 deletions(-) diff --git a/core/presentation/src/main/res/values-tr/strings.xml b/core/presentation/src/main/res/values-tr/strings.xml index dffb0647..da6bada6 100644 --- a/core/presentation/src/main/res/values-tr/strings.xml +++ b/core/presentation/src/main/res/values-tr/strings.xml @@ -51,16 +51,7 @@ \n\nDoğru tahminler alabilmek için veritabanını en az haftada bir güncelleyin. What\'s new in Look4Sat - * Roaming sayfası QTH定位器 2.0\'dan birebir taşındı: 8 haneli konum, 3x3 ızgara, kırmızı işaret, canlı GPS - \n\n* İçeriğin sistem durum/gezinme çubuklarıyla çakışması düzeltildi; ızgara sütunları referans düzenle eşleşiyor - \n\n* Roaming sayfası renkleri uygulama temasını takip eder - kırmızı gece modunda tamamen görünür - \n\n* Ayarlar: sıkışan anahtar satırları ve teşekkür aralığı düzeltildi - \n\n* Uygulama adı artık Look4Sat Pro - \n\n* Ayarlar: "İçe aktar" düğmesi "Özel URL" olarak yeniden adlandırıldı - TLE/alıcı-verici kaynak URL\'leri doğrudan düzenlenebilir - \n\n* Özel kaynak anahtarları varsayılan olarak KAPALI; eski örnek URL\'ler gerçek varsayılanlara sıfırlanır - \n\n* Yeni UI Ayarları kartı: alt gezinme sayfalarını göster/gizle (sıra sabit, Ayarlar her zaman görünür) - \n\n* Sayfa sırası: UI Ayarları\'nda her sayfanın yanındaki tutamacı sürükleyerek alt gezinmeyi yeniden sıralayın, tek dokunuşla varsayılana sıfırlayın - + * Ayarlar sayfasında kaydırırken oluşan çökme düzeltildi (sayfa sırası listesi yüksekliği) Geri diff --git a/core/presentation/src/main/res/values-zh/strings.xml b/core/presentation/src/main/res/values-zh/strings.xml index 8e56f538..38d4b848 100644 --- a/core/presentation/src/main/res/values-zh/strings.xml +++ b/core/presentation/src/main/res/values-zh/strings.xml @@ -40,17 +40,8 @@ 欢迎来到 Look4Sat\! 请务必在设置中通过GPS、经纬度或QTH定位您的位置\n建议至少每周更新一次数据库，以确保预测结果的准确性 Look4Sat Pro 更新内容 - - * 漫游页完整移植 QTH定位器 2.0：8 位网格、3x3 九宫格、红点查表定位、实时 GPS - \n\n* 修复内容被系统状态栏/导航栏遮挡；九宫格列宽与原版一致 - \n\n* 漫游页配色跟随应用主题，红色夜间模式下清晰可见 - \n\n* 设置：修复开关行挤压与感谢列表间距 - \n\n* 应用名现为 Look4Sat Pro - \n\n* 设置：导入文件按钮更名为自定义URL，可直接编辑 TLE/收发机数据源地址 - \n\n* 自定义数据源开关默认关闭；旧版占位 URL 自动重置为真实默认地址 - \n\n* 新增 UI设置 卡片：可显示/隐藏底部菜单栏页面（顺序固定，设置页始终显示） - \n\n* 新增 页面顺序：在 UI设置 中拖动每页右侧抓手可调整底部菜单栏顺序，一键重置为默认顺序 - + + * 修复设置页滑动时闪退的问题（页面顺序列表高度） 后退 diff --git a/core/presentation/src/main/res/values/strings.xml b/core/presentation/src/main/res/values/strings.xml index c0bd47a8..c0f7fd64 100644 --- a/core/presentation/src/main/res/values/strings.xml +++ b/core/presentation/src/main/res/values/strings.xml @@ -53,16 +53,7 @@ \n\nPlease update the database at least weekly to get accurate predictions. What\'s new in Look4Sat - * Roaming page ported verbatim from QTH定位器 2.0: 8-char locator, 3x3 grid, red marker lookup, live GPS - \n\n* Fixed content overlapping the system status/navigation bars; grid columns now match the reference layout - \n\n* Roaming page colors follow the app theme - fully visible in red night mode - \n\n* Settings: fixed squeezed toggle rows and credits spacing - \n\n* App name is now Look4Sat Pro - \n\n* Settings: "Import" button renamed to "Custom URL" - edit TLE/transceiver source URLs directly - \n\n* Custom source toggles default OFF; legacy placeholder URLs are reset to the real defaults - \n\n* New UI Settings card: show/hide bottom navigation pages (order fixed, Settings always visible) - \n\n* Page order: drag the handle next to each page in UI Settings to reorder the bottom navigation, one-tap reset to default - + * Fixed a crash when scrolling the Settings page (page-order list height) Back diff --git a/feature/settings/src/main/java/com/rtbishop/look4sat/feature/settings/SettingsScreen.kt b/feature/settings/src/main/java/com/rtbishop/look4sat/feature/settings/SettingsScreen.kt index 186145d1..da43c4a0 100644 --- a/feature/settings/src/main/java/com/rtbishop/look4sat/feature/settings/SettingsScreen.kt +++ b/feature/settings/src/main/java/com/rtbishop/look4sat/feature/settings/SettingsScreen.kt @@ -617,7 +617,13 @@ private fun DragOrderList( var draggingIndex by remember { mutableIntStateOf(-1) } var dragOffset by remember { mutableStateOf(0f) } - LazyColumn(state = listState, modifier = Modifier.fillMaxWidth()) { + // 固定高度: 嵌套在 LazyVerticalGrid 内必须给有界高度, 否则无限高度约束崩溃 + LazyColumn( + state = listState, + modifier = Modifier + .fillMaxWidth() + .height(itemHeight * items.size) + ) { itemsIndexed(items, key = { _, s -> s.second }) { index, screen -> val isDragging = draggingIndex == index Row(