From 8f34c6d6b9b7d185e5a2cf4bcce331835727dbeb Mon Sep 17 00:00:00 2001 From: Arty Bishop Date: Wed, 27 May 2020 10:07:34 +0100 Subject: [PATCH] Cleaned up strings and styles --- .../ui/adapters/TransmitterAdapter.kt | 4 +- .../look4sat/ui/fragments/MapViewFragment.kt | 2 +- .../look4sat/ui/fragments/PassListFragment.kt | 5 +- .../ui/fragments/PolarViewFragment.kt | 2 +- .../ui/fragments/TleSourcesDialogFragment.kt | 2 + app/src/main/res/drawable/ic_add.xml | 9 ++++ app/src/main/res/layout/dialog_pass_pref.xml | 14 ++++- app/src/main/res/layout/dialog_sat_entry.xml | 29 +++++----- .../main/res/layout/dialog_tle_sources.xml | 53 ++++++++----------- app/src/main/res/layout/dialog_tle_url.xml | 51 ------------------ app/src/main/res/layout/drawer_header.xml | 2 +- app/src/main/res/layout/fragment_map_view.xml | 2 +- .../main/res/layout/fragment_polar_view.xml | 2 +- app/src/main/res/layout/item_tle_source.xml | 1 - app/src/main/res/values-ru/strings.xml | 37 ++++++------- app/src/main/res/values/strings.xml | 42 ++++++--------- app/src/main/res/values/styles.xml | 4 +- 17 files changed, 101 insertions(+), 160 deletions(-) create mode 100644 app/src/main/res/drawable/ic_add.xml delete mode 100644 app/src/main/res/layout/dialog_tle_url.xml diff --git a/app/src/main/java/com/rtbishop/look4sat/ui/adapters/TransmitterAdapter.kt b/app/src/main/java/com/rtbishop/look4sat/ui/adapters/TransmitterAdapter.kt index b9091688..6fb5617e 100644 --- a/app/src/main/java/com/rtbishop/look4sat/ui/adapters/TransmitterAdapter.kt +++ b/app/src/main/java/com/rtbishop/look4sat/ui/adapters/TransmitterAdapter.kt @@ -100,12 +100,12 @@ class TransmitterAdapter : RecyclerView.Adapter + setPositiveButton(getString(android.R.string.ok)) { _, _ -> val hoursStr = etHoursAhead.text.toString() val elevationStr = etMinEl.text.toString() if (hoursStr.isNotEmpty() && elevationStr.isNotEmpty()) { @@ -174,7 +173,7 @@ class PassListFragment : Fragment(R.layout.fragment_pass_list) { ).show() } - setNegativeButton(getString(R.string.btn_cancel)) { dialog, _ -> + setNegativeButton(getString(android.R.string.cancel)) { dialog, _ -> dialog.cancel() } setView(satPassPrefView) diff --git a/app/src/main/java/com/rtbishop/look4sat/ui/fragments/PolarViewFragment.kt b/app/src/main/java/com/rtbishop/look4sat/ui/fragments/PolarViewFragment.kt index 0187cf79..f6706f84 100644 --- a/app/src/main/java/com/rtbishop/look4sat/ui/fragments/PolarViewFragment.kt +++ b/app/src/main/java/com/rtbishop/look4sat/ui/fragments/PolarViewFragment.kt @@ -168,7 +168,7 @@ class PolarViewFragment : Fragment(R.layout.fragment_polar_view), SensorEventLis val satPos = satPass.predictor.getSatPos(Date()) val polarAz = mainActivity.getString(R.string.pat_azimuth) val polarEl = mainActivity.getString(R.string.pat_elevation) - val polarRng = mainActivity.getString(R.string.pat_range) + val polarRng = mainActivity.getString(R.string.pat_distance) val polarAlt = mainActivity.getString(R.string.pat_altitude) binding.tvPolarAz.text = String.format(polarAz, GeneralUtils.rad2Deg(satPos.azimuth)) binding.tvPolarEl.text = String.format(polarEl, GeneralUtils.rad2Deg(satPos.elevation)) diff --git a/app/src/main/java/com/rtbishop/look4sat/ui/fragments/TleSourcesDialogFragment.kt b/app/src/main/java/com/rtbishop/look4sat/ui/fragments/TleSourcesDialogFragment.kt index c6927e43..62efa876 100644 --- a/app/src/main/java/com/rtbishop/look4sat/ui/fragments/TleSourcesDialogFragment.kt +++ b/app/src/main/java/com/rtbishop/look4sat/ui/fragments/TleSourcesDialogFragment.kt @@ -22,6 +22,7 @@ package com.rtbishop.look4sat.ui.fragments import android.app.Dialog import android.os.Bundle import android.view.ViewGroup +import android.view.Window import androidx.appcompat.app.AppCompatDialogFragment import androidx.recyclerview.widget.LinearLayoutManager import com.rtbishop.look4sat.data.TleSource @@ -38,6 +39,7 @@ class TleSourcesDialogFragment(sources: List) : override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { val binding = DialogTleSourcesBinding.inflate(requireActivity().layoutInflater) val tleSourcesDialog = Dialog(requireActivity()).apply { + window?.requestFeature(Window.FEATURE_NO_TITLE) setContentView(binding.root) window?.setLayout( ViewGroup.LayoutParams.MATCH_PARENT, diff --git a/app/src/main/res/drawable/ic_add.xml b/app/src/main/res/drawable/ic_add.xml new file mode 100644 index 00000000..88076db6 --- /dev/null +++ b/app/src/main/res/drawable/ic_add.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/layout/dialog_pass_pref.xml b/app/src/main/res/layout/dialog_pass_pref.xml index 48e9e617..582cb55e 100644 --- a/app/src/main/res/layout/dialog_pass_pref.xml +++ b/app/src/main/res/layout/dialog_pass_pref.xml @@ -23,17 +23,26 @@ android:layout_width="match_parent" android:layout_height="wrap_content"> + + + app:layout_constraintTop_toBottomOf="@+id/pref_tv_title" /> + diff --git a/app/src/main/res/layout/dialog_sat_entry.xml b/app/src/main/res/layout/dialog_sat_entry.xml index c1737a8d..ffc93fb5 100644 --- a/app/src/main/res/layout/dialog_sat_entry.xml +++ b/app/src/main/res/layout/dialog_sat_entry.xml @@ -26,25 +26,24 @@ diff --git a/app/src/main/res/layout/dialog_tle_sources.xml b/app/src/main/res/layout/dialog_tle_sources.xml index 40791a9c..1b8ca885 100644 --- a/app/src/main/res/layout/dialog_tle_sources.xml +++ b/app/src/main/res/layout/dialog_tle_sources.xml @@ -3,45 +3,44 @@ xmlns:app="http://schemas.android.com/apk/res-auto" android:id="@+id/tleSourcesDialog" android:layout_width="match_parent" - android:layout_height="match_parent"> + android:layout_height="match_parent" + android:layout_margin="4dp"> + app:srcCompat="@drawable/ic_add" /> + android:text="@string/https_only" + app:layout_constraintStart_toStartOf="@+id/tleSourcesTitle" + app:layout_constraintTop_toBottomOf="@+id/tleSourcesTitle" /> diff --git a/app/src/main/res/layout/dialog_tle_url.xml b/app/src/main/res/layout/dialog_tle_url.xml deleted file mode 100644 index 05ad3793..00000000 --- a/app/src/main/res/layout/dialog_tle_url.xml +++ /dev/null @@ -1,51 +0,0 @@ - - - - - - - - - - - - \ No newline at end of file diff --git a/app/src/main/res/layout/drawer_header.xml b/app/src/main/res/layout/drawer_header.xml index d8fdf3fe..8391f955 100644 --- a/app/src/main/res/layout/drawer_header.xml +++ b/app/src/main/res/layout/drawer_header.xml @@ -117,7 +117,7 @@ style="@style/DrawerHeader.Button" android:layout_width="0dp" android:drawableEnd="@drawable/ic_update_tle" - android:text="@string/update_tle" + android:text="@string/update_tle_web" app:layout_constraintBottom_toTopOf="@+id/drawer_btn_trans" app:layout_constraintEnd_toStartOf="@+id/guidelineRight" app:layout_constraintStart_toStartOf="@+id/guidelineLeft" diff --git a/app/src/main/res/layout/fragment_map_view.xml b/app/src/main/res/layout/fragment_map_view.xml index 71d582bf..b741447c 100644 --- a/app/src/main/res/layout/fragment_map_view.xml +++ b/app/src/main/res/layout/fragment_map_view.xml @@ -68,7 +68,7 @@ style="@style/MapText" android:layout_marginEnd="4dp" android:layout_marginBottom="4dp" - android:text="@string/pat_range" + android:text="@string/pat_distance" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" /> diff --git a/app/src/main/res/layout/fragment_polar_view.xml b/app/src/main/res/layout/fragment_polar_view.xml index 1ba8465b..7c19bf64 100644 --- a/app/src/main/res/layout/fragment_polar_view.xml +++ b/app/src/main/res/layout/fragment_polar_view.xml @@ -61,7 +61,7 @@ android:id="@+id/tv_polar_rng" style="@style/PolarViewText" android:layout_marginEnd="4dp" - android:text="@string/pat_range" + android:text="@string/pat_distance" app:layout_constraintBottom_toBottomOf="@+id/frame_polar" app:layout_constraintEnd_toEndOf="@+id/frame_polar" /> diff --git a/app/src/main/res/layout/item_tle_source.xml b/app/src/main/res/layout/item_tle_source.xml index 4835a8bd..c99d67cc 100644 --- a/app/src/main/res/layout/item_tle_source.xml +++ b/app/src/main/res/layout/item_tle_source.xml @@ -12,7 +12,6 @@ android:layout_height="wrap_content" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@+id/tleSourceBtnDel" - app:layout_constraintHorizontal_bias="0.5" app:layout_constraintHorizontal_chainStyle="packed" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent"> diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index 05f8630c..94b64bf5 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -25,7 +25,9 @@ Обновить геопозицию Геопозиция обновлена - Обновить файл TLE + Проверьте настройки GPS + Обновить TLE из файла + Обновить TLE по ссылке Файл TLE обновлен Обновить трансиверы База трансиверов обновлена @@ -40,6 +42,7 @@ Выберите спутники для слежения Показать трассу орбиты для Фильтровать пролеты + Управление источниками TLE Количество часов Показать пролеты за след. Х часов @@ -58,6 +61,7 @@ Другие настройки Частота обновления, мс Введите значение между 250мс и 10000мс + Используйте компас при отображении полярных координат Модуляция: нет Восход.: нет @@ -65,24 +69,19 @@ Не найдены трансиверы для этого спутника Отсутствуют необходимые разрешения - Некоторые спутники не пролетят над заданной точкой - Ошибка обработки TLE - Пожалуйста, обновите ваш файл TLE Пожалуйста, введите значение - Не найден файл TLE - Не найден файл выбранных спутников Не выбраны спутники НПС — %2d° - Элевация: %.1f° + Элев.: %.1f° %2d° — КПС - Азимут: %.1f° - Элевация: %.1f° - Широта: %.1f° - Долгота: %.1f° - Дист.: %.0f км - Высота: %.0f км + Аз.: %.1f° + Элев.: %.1f° + Шир.: %.1f° + Дол.: %.1f° + Дист.: %.0f км + Выс.: %.0f км Модуляция: %s Инверсия: %s @@ -133,14 +132,8 @@ в лицензии GNU GPLv2. - Да - Нет - OK - Отмена - Все/Нет - СТЦ - Проверьте ваши настройки GPS - Manage TLE sources - TLE source + Все/Нет + Источник TLE + Пожалуйста, используйте протокол HTTPS diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index aba03515..a9d1db13 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -26,14 +26,13 @@ Longitude: Update location - Location was updated + Location updated Check your Location settings - Import TLE from file - TLE was updated - Import TLE from WEB + Import TLE from file + Import TLE from web TLE was updated Update transceivers - Transceivers database was updated + Transceivers DB updated Check your internet connection GitHub Exit @@ -47,6 +46,7 @@ Select satellites to track Show ground track for Filter passes + Manage TLE sources hoursAhead Hours ahead @@ -69,24 +69,18 @@ Set the value between -413m and 8850m Other rate - View refresh rate, ms + Refresh rate, ms Set the value between 250ms and 10000ms compass - Use sensors to rotate PolarView - Please, enter the HTTPS URL: + Use sensors to rotate PolarView - Mode: Null - Uplink: Null - Downlink: Null - No transceivers found for this Satellite + Mode: null + Uplink: null + Downlink: null + No transceivers found for this satellite Missing permissions - Certain satellites shall not pass - Error parsing TLE entry - Please, update your TLE file Please, enter the value - TLE file was not found - Selection file was not found No satellites selected %s @@ -101,7 +95,7 @@ El: %.1f° Lat: %.1f° Lon: %.1f° - Dst: %.0f km + Dst: %.0f km Alt: %.0f km %02d:%02d:%02d @@ -158,15 +152,9 @@ GNU GPLv2 for details. - Yes - No - OK - Cancel - All/None - GSP - Placeholder - Manage TLE sources - Please use HTTPS URLs only + All/None TLE source + Please use HTTPS URLs only + Placeholder diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 341deaf2..f289e650 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -126,11 +126,11 @@ 2dp -