From 5a8108384f43ab2fd7662c01d90b59e44c6b2273 Mon Sep 17 00:00:00 2001 From: Arty Bishop Date: Sat, 5 Aug 2023 14:01:10 +0100 Subject: [PATCH] Added minor fixes to resources and build scripts --- app/build.gradle.kts | 1 + .../look4sat/presentation/MainScreen.kt | 4 ++-- .../presentation/entries/EntriesScreen.kt | 4 ++-- .../look4sat/presentation/map/MapViewModel.kt | 19 ++--------------- .../presentation/radar/RadarScreen.kt | 4 ++-- .../presentation/settings/SettingsScreen.kt | 2 +- .../drawable/{ic_next.xml => ic_arrow.xml} | 1 - app/src/main/res/drawable/ic_checkbox_off.xml | 1 - app/src/main/res/drawable/ic_checkbox_on.xml | 1 - app/src/main/res/drawable/ic_close.xml | 1 - .../{ic_checkmark.xml => ic_done.xml} | 1 - app/src/main/res/drawable/ic_elevation.xml | 1 - app/src/main/res/drawable/ic_entries.xml | 13 ------------ app/src/main/res/drawable/ic_filter.xml | 1 - app/src/main/res/drawable/ic_passes.xml | 1 - app/src/main/res/drawable/ic_position.xml | 4 +--- app/src/main/res/drawable/ic_radar.xml | 10 --------- app/src/main/res/drawable/ic_search.xml | 1 - app/src/main/res/drawable/ic_settings.xml | 7 +++---- app/src/main/res/drawable/ic_sputnik.xml | 12 +++++++++++ app/src/main/res/drawable/ic_world_map.xml | 1 - app/src/main/res/drawable/launcher_fg.xml | 9 ++++---- app/src/main/res/drawable/splash.xml | 14 ------------- app/src/main/res/values/themes.xml | 2 +- .../look4sat/domain/utility/GeoConverter.kt | 21 ++++++++----------- gradle.properties | 3 +-- settings.gradle => settings.gradle.kts | 7 ++++--- 27 files changed, 45 insertions(+), 101 deletions(-) rename app/src/main/res/drawable/{ic_next.xml => ic_arrow.xml} (91%) rename app/src/main/res/drawable/{ic_checkmark.xml => ic_done.xml} (93%) delete mode 100644 app/src/main/res/drawable/ic_entries.xml delete mode 100644 app/src/main/res/drawable/ic_radar.xml create mode 100644 app/src/main/res/drawable/ic_sputnik.xml delete mode 100644 app/src/main/res/drawable/splash.xml rename settings.gradle => settings.gradle.kts (80%) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index 933b1ff2..3b53357c 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -15,6 +15,7 @@ android { targetSdk = 33 versionCode = 313 versionName = "3.1.3" + resourceConfigurations.addAll(listOf("en", "ru", "si", "zh-rCN", "anydpi")) testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" } buildFeatures { diff --git a/app/src/main/java/com/rtbishop/look4sat/presentation/MainScreen.kt b/app/src/main/java/com/rtbishop/look4sat/presentation/MainScreen.kt index 1d186bff..77be1172 100644 --- a/app/src/main/java/com/rtbishop/look4sat/presentation/MainScreen.kt +++ b/app/src/main/java/com/rtbishop/look4sat/presentation/MainScreen.kt @@ -26,9 +26,9 @@ import com.rtbishop.look4sat.presentation.radar.RadarScreen import com.rtbishop.look4sat.presentation.settings.SettingsScreen sealed class Screen(var title: String, var icon: Int, var route: String) { - data object Entries : Screen("Entries", R.drawable.ic_entries, "entries") + data object Entries : Screen("Entries", R.drawable.ic_sputnik, "entries") data object Passes : Screen("Passes", R.drawable.ic_passes, "passes") - data object Radar : Screen("Radar", R.drawable.ic_radar, "radar") + data object Radar : Screen("Radar", R.drawable.ic_settings, "radar") data object Map : Screen("World Map", R.drawable.ic_world_map, "world_map") data object Settings : Screen("Settings", R.drawable.ic_settings, "settings") } diff --git a/app/src/main/java/com/rtbishop/look4sat/presentation/entries/EntriesScreen.kt b/app/src/main/java/com/rtbishop/look4sat/presentation/entries/EntriesScreen.kt index 1e9cc024..0886cf9d 100644 --- a/app/src/main/java/com/rtbishop/look4sat/presentation/entries/EntriesScreen.kt +++ b/app/src/main/java/com/rtbishop/look4sat/presentation/entries/EntriesScreen.kt @@ -142,7 +142,7 @@ private fun SaveButton(saveSelection: () -> Unit, modifier: Modifier = Modifier) colors = CardDefaults.cardColors(containerColor = MaterialTheme.colorScheme.primary) ) { Box(modifier = clickableModifier.fillMaxSize(), contentAlignment = Alignment.Center) { - Icon(painter = painterResource(id = R.drawable.ic_checkmark), contentDescription = null) + Icon(painter = painterResource(id = R.drawable.ic_done), contentDescription = null) } } } @@ -169,7 +169,7 @@ private fun EntryTypeCard(type: String, onClick: () -> Unit, modifier: Modifier .height(48.dp) .clickable { onClick() }) { Icon( - painter = painterResource(id = R.drawable.ic_next), + painter = painterResource(id = R.drawable.ic_arrow), contentDescription = null, modifier = Modifier .size(36.dp) diff --git a/app/src/main/java/com/rtbishop/look4sat/presentation/map/MapViewModel.kt b/app/src/main/java/com/rtbishop/look4sat/presentation/map/MapViewModel.kt index aa13c5b8..3f28d87b 100644 --- a/app/src/main/java/com/rtbishop/look4sat/presentation/map/MapViewModel.kt +++ b/app/src/main/java/com/rtbishop/look4sat/presentation/map/MapViewModel.kt @@ -29,12 +29,12 @@ import com.rtbishop.look4sat.domain.predict.Satellite import com.rtbishop.look4sat.domain.repository.ISatelliteRepo import com.rtbishop.look4sat.domain.repository.ISettingsRepo import com.rtbishop.look4sat.domain.utility.QthConverter +import com.rtbishop.look4sat.domain.utility.clipLat +import com.rtbishop.look4sat.domain.utility.clipLon import com.rtbishop.look4sat.domain.utility.toDegrees import com.rtbishop.look4sat.domain.utility.toTimerString import java.util.Date import kotlin.collections.set -import kotlin.math.max -import kotlin.math.min import kotlinx.coroutines.Job import kotlinx.coroutines.cancelAndJoin import kotlinx.coroutines.delay @@ -200,21 +200,6 @@ class MapViewModel(private val satelliteRepo: ISatelliteRepo, settingsRepo: ISet _mapData.emit(satData) } - private fun clipLat(latitude: Double): Double { - return clip(latitude, -85.05, 85.05) - } - - private fun clipLon(longitude: Double): Double { - var result = longitude - while (result < -180.0) result += 360.0 - while (result > 180.0) result -= 360.0 - return clip(result, -180.0, 180.0) - } - - private fun clip(currentValue: Double, minValue: Double, maxValue: Double): Double { - return min(max(currentValue, minValue), maxValue) - } - companion object { val Factory: ViewModelProvider.Factory = viewModelFactory { val applicationKey = ViewModelProvider.AndroidViewModelFactory.APPLICATION_KEY diff --git a/app/src/main/java/com/rtbishop/look4sat/presentation/radar/RadarScreen.kt b/app/src/main/java/com/rtbishop/look4sat/presentation/radar/RadarScreen.kt index f5465148..af7332b4 100644 --- a/app/src/main/java/com/rtbishop/look4sat/presentation/radar/RadarScreen.kt +++ b/app/src/main/java/com/rtbishop/look4sat/presentation/radar/RadarScreen.kt @@ -114,7 +114,7 @@ private fun TransmitterItem(radio: SatRadio) { modifier = Modifier.fillMaxWidth() ) { Icon( - painter = painterResource(id = R.drawable.ic_next), + painter = painterResource(id = R.drawable.ic_arrow), contentDescription = null, modifier = Modifier.rotate(180f) ) Text( @@ -123,7 +123,7 @@ private fun TransmitterItem(radio: SatRadio) { textAlign = TextAlign.Center ) Icon( - painter = painterResource(id = R.drawable.ic_next), + painter = painterResource(id = R.drawable.ic_arrow), contentDescription = null ) } diff --git a/app/src/main/java/com/rtbishop/look4sat/presentation/settings/SettingsScreen.kt b/app/src/main/java/com/rtbishop/look4sat/presentation/settings/SettingsScreen.kt index 985ef0f3..52e14841 100644 --- a/app/src/main/java/com/rtbishop/look4sat/presentation/settings/SettingsScreen.kt +++ b/app/src/main/java/com/rtbishop/look4sat/presentation/settings/SettingsScreen.kt @@ -144,7 +144,7 @@ private fun CardAbout(version: String, modifier: Modifier = Modifier) { ) { Row(horizontalArrangement = Arrangement.Center) { Icon( - painter = painterResource(id = R.drawable.ic_entries), + painter = painterResource(id = R.drawable.ic_sputnik), tint = MaterialTheme.colorScheme.secondary, contentDescription = null, modifier = Modifier diff --git a/app/src/main/res/drawable/ic_next.xml b/app/src/main/res/drawable/ic_arrow.xml similarity index 91% rename from app/src/main/res/drawable/ic_next.xml rename to app/src/main/res/drawable/ic_arrow.xml index d0d75ad5..5fbe7d44 100644 --- a/app/src/main/res/drawable/ic_next.xml +++ b/app/src/main/res/drawable/ic_arrow.xml @@ -1,7 +1,6 @@ - - - diff --git a/app/src/main/res/drawable/ic_filter.xml b/app/src/main/res/drawable/ic_filter.xml index 27587037..ced58887 100644 --- a/app/src/main/res/drawable/ic_filter.xml +++ b/app/src/main/res/drawable/ic_filter.xml @@ -1,7 +1,6 @@ diff --git a/app/src/main/res/drawable/ic_radar.xml b/app/src/main/res/drawable/ic_radar.xml deleted file mode 100644 index 3abdac25..00000000 --- a/app/src/main/res/drawable/ic_radar.xml +++ /dev/null @@ -1,10 +0,0 @@ - - - diff --git a/app/src/main/res/drawable/ic_search.xml b/app/src/main/res/drawable/ic_search.xml index 86c5c005..aefdcef5 100644 --- a/app/src/main/res/drawable/ic_search.xml +++ b/app/src/main/res/drawable/ic_search.xml @@ -1,7 +1,6 @@ + android:viewportWidth="960" + android:viewportHeight="960"> + android:pathData="m388,880 l-20,-126q-19,-7 -40,-19t-37,-25l-118,54 -93,-164 108,-79q-2,-9 -2.5,-20.5T185,480q0,-9 0.5,-20.5T188,439L80,360l93,-164 118,54q16,-13 37,-25t40,-18l20,-127h184l20,126q19,7 40.5,18.5T669,250l118,-54 93,164 -108,77q2,10 2.5,21.5t0.5,21.5q0,10 -0.5,21t-2.5,21l108,78 -93,164 -118,-54q-16,13 -36.5,25.5T592,754L572,880L388,880ZM480,610q54,0 92,-38t38,-92q0,-54 -38,-92t-92,-38q-54,0 -92,38t-38,92q0,54 38,92t92,38Z" /> diff --git a/app/src/main/res/drawable/ic_sputnik.xml b/app/src/main/res/drawable/ic_sputnik.xml new file mode 100644 index 00000000..9134f202 --- /dev/null +++ b/app/src/main/res/drawable/ic_sputnik.xml @@ -0,0 +1,12 @@ + + + + diff --git a/app/src/main/res/drawable/ic_world_map.xml b/app/src/main/res/drawable/ic_world_map.xml index 0475f149..7a1ab400 100644 --- a/app/src/main/res/drawable/ic_world_map.xml +++ b/app/src/main/res/drawable/ic_world_map.xml @@ -1,7 +1,6 @@ + android:viewportWidth="271.24" + android:viewportHeight="271.24"> @@ -12,10 +11,10 @@ android:translateY="70.26573"> + android:pathData="m96.64,31.5c7.91,8 17.14,13.58 25.36,15.58l1.75,-4C123.78,43.05 123.79,43.01 123.8,42.97 125.83,38.99 127,34.49 127,29.72 127,13.88 114.38,1 98.87,1c-5.13,0 -9.92,1.43 -14.06,3.88l-3.4,1.6c0.08,0.31 0.13,0.6 0.22,0.91 2.32,8.1 7.65,16.67 15.02,24.11z" /> + android:pathData="M93.88,34.3C86.05,26.39 80.37,17.23 77.87,8.49 77.84,8.39 77.82,8.28 77.79,8.18L2.63,43.51c-1.4,0.66 -2.02,2.36 -1.37,3.79 0.47,1.05 1.49,1.66 2.55,1.66 0.39,0 0.79,-0.08 1.17,-0.26L74.04,16.24c-1.87,3.58 -3,7.61 -3.23,11.89L35.57,51.73c-1.29,0.87 -1.65,2.64 -0.81,3.96 0.54,0.84 1.43,1.29 2.34,1.29 0.53,0 1.06,-0.15 1.53,-0.47L71.19,34.71c1.4,8.11 6.14,15.04 12.72,19.28l-54.94,68.34c-0.98,1.22 -0.81,3.02 0.39,4.02 0.52,0.44 1.15,0.65 1.77,0.65 0.81,0 1.61,-0.36 2.17,-1.04L89.06,56.6c3.06,1.17 6.36,1.84 9.81,1.84 4.93,0 9.57,-1.31 13.6,-3.6L84.6,118.32c-0.63,1.44 0,3.13 1.41,3.78 0.37,0.17 0.76,0.25 1.14,0.25 1.07,0 2.09,-0.63 2.56,-1.69L120.4,50.74C111.64,48.42 102.04,42.56 93.88,34.3Z" /> diff --git a/app/src/main/res/drawable/splash.xml b/app/src/main/res/drawable/splash.xml deleted file mode 100644 index b8048e23..00000000 --- a/app/src/main/res/drawable/splash.xml +++ /dev/null @@ -1,14 +0,0 @@ - - - - - diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml index b6c978b0..98fe171e 100644 --- a/app/src/main/res/values/themes.xml +++ b/app/src/main/res/values/themes.xml @@ -7,7 +7,7 @@ false @style/Theme.Look4Sat.Main @color/background - @drawable/splash + @drawable/launcher_fg