feat(wavelog): 二选一互斥模式 + p12 空密码导入修复(4.4.8-ba7opf.9.4, 569)

- LoTW/Wavelog 互斥:isReady 即 Wavelog 模式,LoTW 卡置灰+说明,上传按模式分流(雷达页/日志本),自动 LoTW 同步门控;配置切换弹警告、可清除配置
- 同步重做:get_contacts_adif 每台址游标,增量/全量双按钮,只增不删,URL 变更增量降级全量;同步刷新日志本+地图 workedGrids/gridQsos/roamedGrids
- 日志本台址选择器(全部/各台址)+ Wavelog 上传预览弹窗;Qso 增 wavelogStation,DB v4→v5
- 删旧 WavelogRepository/wavelogSettings 链路,换 WavelogSyncRepository + WavelogSync 纯函数
- p12 修复:导入按钮放开空密码(isEnabled=!busy)+ 密码框留空提示;Pkcs12ReaderTest +4 用例
- 单测六模块全绿;版本 4.4.8-ba7opf.9.4 (569)
This commit is contained in:
atsunatsu committed 2026-10-05 14:57:46 +08:00
1 parent 1fa7dd2d88
commit 09539ff13a
40 files changed
+1715 -470

No files matched your search

@@ -48,6 +48,6 @@ interface QsoDao {
@Query("UPDATE qso_records SET lotwUploaded = 1 WHERE id IN (:ids)")
suspend fun markUploaded(ids: List<Long>)
@Query("UPDATE qso_records SET wavelogUploaded = 1 WHERE id IN (:ids)")
suspend fun markWavelogUploaded(ids: List<Long>)
@Query("UPDATE qso_records SET wavelogUploaded = 1, wavelogStation = CASE WHEN :stationId = '' THEN wavelogStation ELSE :stationId END WHERE id IN (:ids)")
suspend fun markWavelogUploaded(ids: List<Long>, stationId: String)
}
@@ -20,7 +20,7 @@ import com.rtbishop.look4sat.core.data.database.entity.QsoEntity
* upload receipts). Kept apart from [Look4SatDb] so existing installations
* never need a migration of the satellite database.
*/
@Database(entities = [QsoEntity::class], version = 4, exportSchema = false)
@Database(entities = [QsoEntity::class], version = 5, exportSchema = false)
abstract class QsoDatabase : RoomDatabase() {
abstract fun qsoDao(): QsoDao
}
@@ -45,3 +45,10 @@ val MIGRATION_QSO_3_4 = object : Migration(3, 4) {
db.execSQL("ALTER TABLE qso_records ADD COLUMN wavelogUploaded INTEGER NOT NULL DEFAULT 0")
}
}
/** v4 → v5: remember which Wavelog station profile (台址) a QSO belongs to. */
val MIGRATION_QSO_4_5 = object : Migration(4, 5) {
override fun migrate(db: SupportSQLiteDatabase) {
db.execSQL("ALTER TABLE qso_records ADD COLUMN wavelogStation TEXT NOT NULL DEFAULT ''")
}
}
@@ -45,6 +45,7 @@ data class QsoEntity(
@ColumnInfo(defaultValue = "0") val lotwConfirmed: Boolean = false,
@ColumnInfo(defaultValue = "0") val lotwUploaded: Boolean = false,
@ColumnInfo(defaultValue = "0") val wavelogUploaded: Boolean = false,
@ColumnInfo(defaultValue = "''") val wavelogStation: String = "",
@ColumnInfo(defaultValue = "0") val lotwReceived: Boolean = false,
@ColumnInfo(defaultValue = "''") val lotwQslDate: String = "",
@ColumnInfo(defaultValue = "''") val vuccGrids: String = "",
@@ -32,6 +32,7 @@ import com.rtbishop.look4sat.core.data.database.MIGRATION_2_3
import com.rtbishop.look4sat.core.data.database.MIGRATION_QSO_1_2
import com.rtbishop.look4sat.core.data.database.MIGRATION_QSO_2_3
import com.rtbishop.look4sat.core.data.database.MIGRATION_QSO_3_4
import com.rtbishop.look4sat.core.data.database.MIGRATION_QSO_4_5
import com.rtbishop.look4sat.core.data.database.QsoDatabase
import com.rtbishop.look4sat.core.data.framework.BluetoothReporter
import com.rtbishop.look4sat.core.data.framework.Ft817Controller
@@ -49,8 +50,9 @@ import com.rtbishop.look4sat.core.data.repository.SettingsRepo
import com.rtbishop.look4sat.core.data.repository.UpdateRepository
import com.rtbishop.look4sat.core.data.repository.LoTWRepository
import com.rtbishop.look4sat.core.data.repository.LocationRepo
import com.rtbishop.look4sat.core.data.repository.WavelogRepository
import com.rtbishop.look4sat.core.data.repository.WavelogUploadRepository
import com.rtbishop.look4sat.core.data.repository.WavelogSyncRepository
import com.rtbishop.look4sat.core.data.source.LocalSource
import com.rtbishop.look4sat.core.data.source.RemoteSource
import com.rtbishop.look4sat.core.data.usecase.AddToCalendar
@@ -71,8 +73,9 @@ import com.rtbishop.look4sat.core.domain.repository.ISatelliteRepo
import com.rtbishop.look4sat.core.domain.repository.ISelectionRepo
import com.rtbishop.look4sat.core.domain.repository.ISensorsRepo
import com.rtbishop.look4sat.core.domain.repository.ISettingsRepo
import com.rtbishop.look4sat.core.domain.repository.IWavelogRepository
import com.rtbishop.look4sat.core.domain.repository.IWavelogUploadRepository
import com.rtbishop.look4sat.core.domain.repository.IWavelogSyncRepository
import com.rtbishop.look4sat.core.domain.repository.MutualPassData
import com.rtbishop.look4sat.core.domain.source.ILocalSource
import com.rtbishop.look4sat.core.domain.source.IRemoteSource
@@ -103,12 +106,14 @@ class MainContainer(private val context: Context) : IMainContainer {
override val databaseRepo = provideDatabaseRepo()
override val amSatRepo by lazy { AmSatRepository(remoteSource, appScope) }
override val updateRepo by lazy { UpdateRepository(remoteSource) }
override val wavelogRepo: IWavelogRepository by lazy { WavelogRepository() }
override val wavelogUploadRepository: IWavelogUploadRepository by lazy { WavelogUploadRepository() }
override val wavelogSyncRepository: IWavelogSyncRepository by lazy { WavelogSyncRepository() }
override val lotwRepo: ILoTWRepository by lazy { LoTWRepository() }
override val qsoRepository: IQsoRepository by lazy {
val database = Room.databaseBuilder(context, QsoDatabase::class.java, "Look4SatQsoDB")
.addMigrations(MIGRATION_QSO_1_2, MIGRATION_QSO_2_3, MIGRATION_QSO_3_4)
.addMigrations(MIGRATION_QSO_4_5)
.build()
QsoRepository(database.qsoDao(), Dispatchers.IO)
}
@@ -59,6 +59,7 @@ class QsoRepository(
id = 0L,
lotwUploaded = false, lotwConfirmed = false, lotwReceived = false,
wavelogUploaded = false,
wavelogStation = "",
lotwQslDate = "", vuccGrids = emptyList(), theirVuccGrids = emptyList(),
dxcc = null, country = "", cqZone = null, region = ""
).toEntity())
@@ -95,9 +96,9 @@ class QsoRepository(
if (stamped.isNotEmpty()) dao.saveBatch(stamped.map { it.toEntity() })
}
override suspend fun markWavelogUploaded(ids: List<Long>) = withContext(dispatcher) {
override suspend fun markWavelogUploaded(ids: List<Long>, stationId: String) = withContext(dispatcher) {
if (ids.isEmpty()) return@withContext
importMutex.withLock { dao.markWavelogUploaded(ids) }
importMutex.withLock { dao.markWavelogUploaded(ids, stationId) }
}
override suspend fun exportAdi(ids: Set<Long>?, includeIncomplete: Boolean): String = withContext(dispatcher) {
@@ -124,6 +125,19 @@ class QsoRepository(
importMutex.withLock { mergeRecords(records, fromLoTW = true) }
}
/**
* Merges QSO records pulled from Wavelog (the sync/download direction).
*
* Matching uses the same [stableQsoKey] identity as every other import, so a record
* already recorded locally (typically uploaded from this app) is not duplicated — it
* simply learns its Wavelog station profile and, where the local row is missing them,
* the opposite-station fields the server kept. Fresh records are inserted already
* marked as uploaded, so a later upload never sends them straight back.
*/
override suspend fun mergeWavelog(records: List<QsoRecord>): AdifImportResult = withContext(dispatcher) {
importMutex.withLock { mergeWavelogRecords(records) }
}
override suspend fun consolidateConfirmations(): Int = withContext(dispatcher) {
importMutex.withLock {
val working = dao.getAll().map(QsoEntity::toDomain).toMutableList()
@@ -216,6 +230,56 @@ class QsoRepository(
return AdifImportResult(imported, skipped, updated)
}
private suspend fun mergeWavelogRecords(records: List<QsoRecord>): AdifImportResult {
val working = dao.getAll().map(QsoEntity::toDomain).toMutableList()
// Rows imported under a tracking-source name join the ARRL name first, so the
// lookup below sees one identity for both sides of a match.
val renames = rewriteOfficialNames(working)
val indexByKey = HashMap<String, Int>(working.size)
working.indices.forEach { index -> indexByKey.putIfAbsent(stableQsoKey(working[index]), index) }
val changes = linkedMapOf<Int, QsoRecord>().apply { putAll(renames) }
var imported = 0
var updated = renames.size
var skipped = 0
val seenKeys = hashSetOf<String>()
records.forEach { remote ->
val key = stableQsoKey(remote)
if (!seenKeys.add(key)) {
skipped++
return@forEach
}
val index = indexByKey[key]
if (index == null) {
val added = remote.copy(
id = 0L,
wavelogUploaded = true,
satelliteName = officialSatelliteName(remote.satelliteName)
)
changes[working.size] = added
indexByKey[stableQsoKey(added)] = working.size
working += added
imported++
} else {
val previous = working[index]
val merged = previous.copy(
wavelogUploaded = true,
wavelogStation = remote.wavelogStation.ifBlank { previous.wavelogStation },
theirGrid = previous.theirGrid.ifBlank { remote.theirGrid },
theirVuccGrids = previous.theirVuccGrids.ifEmpty { remote.theirVuccGrids }
)
if (merged != previous) {
working[index] = merged
changes[index] = merged
updated++
} else {
skipped++
}
}
}
dao.saveBatch(changes.values.map { it.toEntity() })
return AdifImportResult(imported, skipped, updated)
}
/** Result of folding already-split rows back together. */
private data class Consolidation(
/** index in the stored list -> the record to save (local row + its confirmation). */
@@ -294,6 +358,7 @@ private fun QsoEntity.toDomain() = QsoRecord(
lotwConfirmed = lotwConfirmed,
lotwUploaded = lotwUploaded,
wavelogUploaded = wavelogUploaded,
wavelogStation = wavelogStation,
lotwReceived = lotwReceived,
lotwQslDate = lotwQslDate,
vuccGrids = vuccGrids.split(',').filter(String::isNotBlank),
@@ -332,6 +397,7 @@ private fun QsoRecord.toEntity() = QsoEntity(
lotwConfirmed = lotwConfirmed,
lotwUploaded = lotwUploaded,
wavelogUploaded = wavelogUploaded,
wavelogStation = wavelogStation.trim(),
lotwReceived = lotwReceived,
lotwQslDate = lotwQslDate,
vuccGrids = vuccGrids.joinToString(","),
@@ -30,7 +30,7 @@ import com.rtbishop.look4sat.core.domain.model.OtherSettings
import com.rtbishop.look4sat.core.domain.model.PassesSettings
import com.rtbishop.look4sat.core.domain.model.RCSettings
import com.rtbishop.look4sat.core.domain.model.RadioControlSettings
import com.rtbishop.look4sat.core.domain.model.WavelogSettings
import com.rtbishop.look4sat.core.domain.model.WavelogUploadSettings
import com.rtbishop.look4sat.core.domain.predict.GeoPos
import com.rtbishop.look4sat.core.domain.repository.ISettingsRepo
@@ -148,27 +148,9 @@ class SettingsRepo(
}
//endregion
//region # Wavelog worked-grids settings
private val keyWavelogUrl = "wavelogUrl"
private val keyWavelogToken = "wavelogToken"
//region # Worked-grid data (written by the LoTW / Wavelog syncs)
private val keyWorkedGrids = "workedGrids"
private val _wavelogSettings = MutableStateFlow(getWavelogSettings())
override val wavelogSettings: StateFlow<WavelogSettings> = _wavelogSettings
override fun updateWavelogSettings(settings: WavelogSettings) {
preferences.edit {
putString(keyWavelogUrl, settings.url.trim())
putString(keyWavelogToken, settings.token.trim())
}
_wavelogSettings.value = settings.copy(url = settings.url.trim(), token = settings.token.trim())
}
private fun getWavelogSettings(): WavelogSettings = WavelogSettings(
url = preferences.getString(keyWavelogUrl, null).orEmpty(),
token = preferences.getString(keyWavelogToken, null).orEmpty()
)
override fun getWorkedGrids(): Set<String> {
val json = preferences.getString(keyWorkedGrids, null).orEmpty()
if (json.isBlank()) return emptySet()
@@ -421,6 +403,78 @@ class SettingsRepo(
)
//endregion
//region # Wavelog sync bookkeeping
private val keyWavelogStations = "wavelogStations"
private val keyWavelogSyncCursors = "wavelogSyncCursors"
private val keyWavelogSyncUrl = "wavelogSyncUrl"
private val keyLastWavelogSyncEpochMs = "wavelogLastSyncEpochMs"
override fun getWavelogStations(): List<com.rtbishop.look4sat.core.domain.repository.WavelogStationInfo> {
val json = preferences.getString(keyWavelogStations, null).orEmpty()
if (json.isBlank()) return emptyList()
return try {
val array = org.json.JSONArray(json)
(0 until array.length()).mapNotNull { i ->
val o = array.optJSONObject(i) ?: return@mapNotNull null
val id = o.optString("id").ifBlank { return@mapNotNull null }
com.rtbishop.look4sat.core.domain.repository.WavelogStationInfo(
id = id,
name = o.optString("name"),
callsign = o.optString("call"),
grid = o.optString("grid"),
active = o.optBoolean("active", true)
)
}
} catch (_: Exception) {
emptyList()
}
}
override fun setWavelogStations(stations: List<com.rtbishop.look4sat.core.domain.repository.WavelogStationInfo>) {
val array = org.json.JSONArray()
stations.forEach { station ->
array.put(
org.json.JSONObject()
.put("id", station.id)
.put("name", station.name)
.put("call", station.callsign)
.put("grid", station.grid)
.put("active", station.active)
)
}
preferences.edit { putString(keyWavelogStations, array.toString()) }
}
override fun getWavelogSyncCursors(): Map<String, Long> {
val json = preferences.getString(keyWavelogSyncCursors, null).orEmpty()
if (json.isBlank()) return emptyMap()
return try {
val root = org.json.JSONObject(json)
root.keys().asSequence().associateWith { key -> root.optLong(key, 0L) }
} catch (_: Exception) {
emptyMap()
}
}
override fun setWavelogSyncCursors(cursors: Map<String, Long>) {
val root = org.json.JSONObject()
cursors.forEach { (stationId, cursor) -> root.put(stationId, cursor) }
preferences.edit { putString(keyWavelogSyncCursors, root.toString()) }
}
override fun getWavelogSyncUrl(): String =
preferences.getString(keyWavelogSyncUrl, null).orEmpty()
override fun setWavelogSyncUrl(url: String) =
preferences.edit { putString(keyWavelogSyncUrl, url) }
override fun getLastWavelogSyncEpochMs(): Long =
preferences.getLong(keyLastWavelogSyncEpochMs, 0L)
override fun setLastWavelogSyncEpochMs(value: Long) =
preferences.edit { putLong(keyLastWavelogSyncEpochMs, value) }
//endregion
//region # Transceivers settings
private val _passesSettings = MutableStateFlow(getPassesSettings())
override val passesSettings: StateFlow<PassesSettings> = _passesSettings
@@ -1,97 +0,0 @@
/*
* Look4Sat. Amateur radio satellite tracker and pass predictor.
* Copyright (C) 2019-2026 Arty Bishop and contributors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package com.rtbishop.look4sat.core.data.repository
import com.rtbishop.look4sat.core.domain.repository.IWavelogRepository
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import org.json.JSONArray
import org.json.JSONObject
/**
* Fetches the list of worked gridsquares from a self-hosted Wavelog instance.
*
* Uses the Wavelog v1 API endpoint (verified against Wavelog 3.0.2):
* POST {base}/index.php/api/logbook_get_worked_grids
* Body: {"key": "<api key>", "logbook_id": "<logbook id>"}
* Response 201: JSON array of 4-char gridsquares, e.g. ["JN47","JO30"]
* (see Wavelog Api.php logbook_get_worked_grids / Api_model::get_grids_worked_in_logbook)
*
* The token field carries "<api_key>:<logbook_id>" so one credential line
* configures both values (the dialog explains this to the user).
*/
class WavelogRepository : IWavelogRepository {
override suspend fun fetchWorkedGrids(url: String, token: String): Set<String>? = withContext(Dispatchers.IO) {
val parts = token.trim().split(":")
val apiKey = parts.getOrNull(0)?.trim().orEmpty()
val logbookId = parts.getOrNull(1)?.trim().orEmpty()
if (url.isBlank() || apiKey.isBlank() || logbookId.isBlank()) return@withContext null
val base = url.trim().trimEnd('/')
val requestUrl = "$base/index.php/api/logbook_get_worked_grids"
try {
val connection = java.net.URL(requestUrl).openConnection() as java.net.HttpURLConnection
connection.connectTimeout = 10_000
connection.readTimeout = 15_000
connection.requestMethod = "POST"
connection.doOutput = true
connection.setRequestProperty("Content-Type", "application/json")
val body = JSONObject().apply {
put("key", apiKey)
put("logbook_id", logbookId)
}.toString().toByteArray()
connection.outputStream.use { it.write(body) }
val code = connection.responseCode
if (code !in 200..299) {
connection.disconnect()
return@withContext null
}
val response = connection.inputStream.bufferedReader().use { it.readText() }
connection.disconnect()
parseWorkedGrids(response)
} catch (e: Exception) {
println("WavelogRepository fetch failure: $e")
null
}
}
internal fun parseWorkedGrids(body: String): Set<String>? {
return try {
val array = when {
body.trimStart().startsWith("[") -> JSONArray(body)
else -> {
// Tolerate {"grids": [...]} wrappers too
JSONObject(body).optJSONArray("grids") ?: return null
}
}
val result = mutableSetOf<String>()
for (i in 0 until array.length()) {
val grid = array.optString(i, "").trim().uppercase()
// Keep only well-formed 4-character Maidenhead squares (e.g. OL62)
if (grid.length == 4 && grid[0] in 'A'..'R' && grid[1] in 'A'..'R'
&& grid[2] in '0'..'9' && grid[3] in '0'..'9'
) {
result.add(grid)
}
}
result
} catch (_: Exception) {
null
}
}
}
@@ -0,0 +1,142 @@
/*
* Look4Sat-BA7OPF. Amateur radio satellite tracker and pass predictor.
* Copyright (C) 2026 BA7OPF.
* Based on Look4Sat by Arty Bishop and contributors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package com.rtbishop.look4sat.core.data.repository
import com.rtbishop.look4sat.core.domain.logbook.AdifCodec
import com.rtbishop.look4sat.core.domain.logbook.QsoRecord
import com.rtbishop.look4sat.core.domain.repository.IWavelogSyncRepository
import com.rtbishop.look4sat.core.domain.repository.WavelogStationInfo
import com.rtbishop.look4sat.core.domain.repository.WavelogSyncFetch
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import okhttp3.MediaType.Companion.toMediaType
import okhttp3.OkHttpClient
import okhttp3.Request
import okhttp3.RequestBody.Companion.toRequestBody
import org.json.JSONArray
import org.json.JSONObject
import java.util.concurrent.CancellationException
import java.util.concurrent.TimeUnit
/**
* Pulls QSO records from a self-hosted Wavelog via the v1 API.
*
* Verified against Wavelog 3.0.2 (`Api.php::get_contacts_adif`):
* - `POST {base}/index.php/api/get_contacts_adif`
* with `{"key", "station_id": [id...], "fetchfromid": <last id>, "limit"}`.
* - Responds `{"status":"successful","lastfetchedid":<id>,"exported_qsos":N,"adif":"..."}`;
* only rows whose internal id is greater than `fetchfromid` are exported, so the cursor
* makes the pull incremental. Each station keeps its own cursor: a station profile added
* later starts from 0 and pulls its full history without touching the others'.
* - The export is a full ADIF document; decoding reuses [AdifCodec].
*/
class WavelogSyncRepository internal constructor(
client: OkHttpClient = OkHttpClient()
) : IWavelogSyncRepository {
private val client = client.newBuilder()
.connectTimeout(15, TimeUnit.SECONDS)
.readTimeout(120, TimeUnit.SECONDS)
.callTimeout(180, TimeUnit.SECONDS)
.retryOnConnectionFailure(false)
.build()
private val jsonType = "application/json; charset=utf-8".toMediaType()
override suspend fun fetchNewRecords(
url: String,
apiKey: String,
stations: List<WavelogStationInfo>,
cursors: Map<String, Long>,
full: Boolean
): WavelogSyncFetch? = withContext(Dispatchers.IO) {
val base = url.trim().trimEnd('/')
val key = apiKey.trim()
if (base.isBlank() || key.isBlank() || stations.isEmpty()) return@withContext null
val records = mutableListOf<QsoRecord>()
val newCursors = mutableMapOf<String, Long>()
val failed = mutableListOf<String>()
// Every station profile is fetched (including ones the server marks inactive:
// their historical QSOs still belong to the account and the logbook shows them).
stations.forEach { station ->
var cursor = if (full) 0L else cursors[station.id] ?: 0L
var advanced = false
var stationFailed = false
try {
var guard = 0
while (guard++ < MAX_CHUNKS_PER_STATION) {
val page = fetchPage(base, key, station.id, cursor)
if (page == null) {
stationFailed = true
break
}
cursor = maxOf(cursor, page.cursor)
advanced = true
page.records.forEach { records += it.copy(wavelogStation = station.id) }
if (page.exported < CHUNK_LIMIT) break
}
} catch (e: CancellationException) {
throw e
} catch (_: Exception) {
stationFailed = true
}
// A partially fetched station keeps the cursor of its last good page, so the
// next sync resumes exactly where this one stopped — nothing is fetched twice
// and nothing is skipped.
if (advanced) newCursors[station.id] = cursor
if (stationFailed) failed += station.id
}
WavelogSyncFetch(records, newCursors, failed)
}
internal data class Page(val records: List<QsoRecord>, val cursor: Long, val exported: Int)
private fun fetchPage(base: String, key: String, stationId: String, fromId: Long): Page? {
val body = JSONObject().apply {
put("key", key)
put("station_id", JSONArray().put(stationId))
put("fetchfromid", fromId)
put("limit", CHUNK_LIMIT)
}.toString()
val request = Request.Builder()
.url("$base/index.php/api/get_contacts_adif")
.post(body.toRequestBody(jsonType))
.build()
return client.newCall(request).execute().use { response ->
if (!response.isSuccessful) return@use null
parsePage(response.body.string())
}
}
internal fun parsePage(text: String): Page? {
val json = runCatching { JSONObject(text) }.getOrNull() ?: return null
if (json.optString("status") != "successful") return null
if (!json.has("lastfetchedid")) return null
val cursor = json.optLong("lastfetchedid", 0L)
val exported = json.optInt("exported_qsos", 0)
val adif = json.optString("adif")
if (adif.isBlank()) return Page(emptyList(), cursor, exported)
return Page(AdifCodec.decode(adif), cursor, exported)
}
private companion object {
const val CHUNK_LIMIT = 5000
const val MAX_CHUNKS_PER_STATION = 200
}
}
@@ -131,4 +131,40 @@ class Pkcs12ReaderTest {
Pkcs12Reader.read("not a p12 file at all".toByteArray(), "x".toCharArray())
}
}
@Test
fun readsEmptyPasswordCertpbeNoneLayout() {
// Certificates exported without a password must import with an empty char
// array — the reader must decrypt, not demand a password.
val (key, cert) = Pkcs12Reader.read(fixture("test_pbes2_empty.p12"), charArrayOf())
assertEquals("RSA", key.algorithm)
assertTrue("key/cert pair", keyMatches(key, cert))
}
@Test
fun readsEmptyPasswordEncryptedCertLayout() {
val (key, cert) = Pkcs12Reader.read(fixture("test_pbes2_empty_enc.p12"), charArrayOf())
assertEquals("RSA", key.algorithm)
assertTrue("key/cert pair", keyMatches(key, cert))
}
@Test
fun emptyPasswordOnProtectedFileFailsAsDecrypt() {
// Blank input on a password-protected file must fail as a decryption error
// (mapped to "password" upstream) — never silently succeed.
val e = assertThrows(Exception::class.java) {
Pkcs12Reader.read(fixture(), charArrayOf())
}
assertTrue("BadPadding", e is javax.crypto.BadPaddingException)
}
@Test
fun platformKeystoreAcceptsEmptyPassword() {
// LoTWKeyMaterial first tries the platform PKCS12 KeyStore: verify the
// empty-password load/getKey call convention this fix relies on.
val ks = java.security.KeyStore.getInstance("PKCS12")
ks.load(fixture("test_pbes2_empty.p12").inputStream(), charArrayOf())
val alias = ks.aliases().nextElement()
assertNotNull(ks.getKey(alias, charArrayOf()))
}
}
@@ -453,10 +453,9 @@ private class FakeSettingsRepo(dataSources: DataSourcesSettings = defaultDataSou
override fun setAmSatCallsign(callsign: String) = Unit
override val wavelogSettings: StateFlow<com.rtbishop.look4sat.core.domain.model.WavelogSettings> =
MutableStateFlow(com.rtbishop.look4sat.core.domain.model.WavelogSettings())
override fun updateWavelogSettings(settings: com.rtbishop.look4sat.core.domain.model.WavelogSettings) = Unit
override val wavelogUploadSettings: StateFlow<com.rtbishop.look4sat.core.domain.model.WavelogUploadSettings> =
MutableStateFlow(com.rtbishop.look4sat.core.domain.model.WavelogUploadSettings())
@@ -479,6 +478,14 @@ private class FakeSettingsRepo(dataSources: DataSourcesSettings = defaultDataSou
override fun setLastLotwSyncDate(date: String) = Unit
override fun getLastLotwSyncCallsign(): String = ""
override fun setLastLotwSyncCallsign(callsign: String) = Unit
override fun getWavelogStations(): List<com.rtbishop.look4sat.core.domain.repository.WavelogStationInfo> = emptyList()
override fun setWavelogStations(stations: List<com.rtbishop.look4sat.core.domain.repository.WavelogStationInfo>) = Unit
override fun getWavelogSyncCursors(): Map<String, Long> = emptyMap()
override fun setWavelogSyncCursors(cursors: Map<String, Long>) = Unit
override fun getWavelogSyncUrl(): String = ""
override fun setWavelogSyncUrl(url: String) = Unit
override fun getLastWavelogSyncEpochMs(): Long = 0L
override fun setLastWavelogSyncEpochMs(value: Long) = Unit
override fun getWorkedGridQsos(): Map<String, List<com.rtbishop.look4sat.core.domain.model.GridQso>> = emptyMap()
@@ -296,14 +296,15 @@ class QsoRepositoryTest {
}
@Test
fun markWavelogUploaded_setsOnlyTheWavelogFlag() = runBlocking {
fun markWavelogUploaded_setsTheFlagAndTheStationStamp() = runBlocking {
val id = dao.save(loggedInApp("SO-50", lotwUploaded = false).toEntity())
repository.markWavelogUploaded(listOf(id))
repository.markWavelogUploaded(listOf(id), "3")
val row = dao.getAll().single()
assertTrue(row.wavelogUploaded)
assertFalse(row.lotwUploaded)
assertEquals("3", row.wavelogStation)
}
@Test
@@ -316,6 +317,46 @@ class QsoRepositoryTest {
assertEquals(1, dao.getAll().count { it.wavelogUploaded })
}
@Test
fun mergeWavelog_insertsNewRecordsAlreadyMarkedAndStationTagged() = runBlocking {
val result = repository.mergeWavelog(
listOf(loggedInApp("SO-50", lotwUploaded = false).copy(wavelogStation = "2"))
)
assertEquals(1, result.imported)
val row = dao.getAll().single()
assertTrue(row.wavelogUploaded)
assertEquals("2", row.wavelogStation)
assertFalse(row.lotwUploaded)
}
@Test
fun mergeWavelog_matchesALocalRowInsteadOfDuplicating() = runBlocking {
val id = dao.save(loggedInApp("SAUDISAT 1C", lotwUploaded = false).copy(wavelogUploaded = true).toEntity())
repository.mergeWavelog(
listOf(loggedInApp("SAUDISAT 1C", lotwUploaded = false).copy(wavelogStation = "1", theirGrid = "EN52"))
)
val rows = dao.getAll()
assertEquals(1, rows.size)
assertEquals(id, rows.first().id)
assertEquals("1", rows.first().wavelogStation)
assertEquals("EN52", rows.first().theirGrid)
// The row joins the ARRL spelling like every other import path.
assertEquals("SO-50", rows.first().satelliteName)
}
@Test
fun mergeWavelog_isIdempotentAcrossSyncs() = runBlocking {
val records = listOf(loggedInApp("SO-50", lotwUploaded = false).copy(wavelogStation = "1"))
repository.mergeWavelog(records)
repository.mergeWavelog(records)
assertEquals(1, dao.getAll().size)
}
/** A record as the log page creates it: tracker name, repeater pair, uplink band. */
private fun loggedInApp(satelliteName: String, lotwUploaded: Boolean) = QsoRecord(
startUtcMillis = qsoStart,
@@ -377,6 +418,7 @@ class QsoRepositoryTest {
lotwConfirmed = lotwConfirmed,
lotwUploaded = lotwUploaded,
wavelogUploaded = wavelogUploaded,
wavelogStation = wavelogStation,
lotwReceived = lotwReceived,
lotwQslDate = lotwQslDate,
vuccGrids = vuccGrids.joinToString(","),
@@ -416,8 +458,15 @@ class QsoRepositoryTest {
ids.forEach { id -> rows[id]?.let { rows[id] = it.copy(lotwUploaded = true) } }
}
override suspend fun markWavelogUploaded(ids: List<Long>) {
ids.forEach { id -> rows[id]?.let { rows[id] = it.copy(wavelogUploaded = true) } }
override suspend fun markWavelogUploaded(ids: List<Long>, stationId: String) {
ids.forEach { id ->
rows[id]?.let {
rows[id] = it.copy(
wavelogUploaded = true,
wavelogStation = if (stationId.isBlank()) it.wavelogStation else stationId
)
}
}
}
}
}
@@ -344,8 +344,7 @@ private class FakeSettingsRepoForSearch : ISettingsRepo {
override val radioControlSettings: StateFlow<RadioControlSettings> = MutableStateFlow(
RadioControlSettings(false, RadioControlSettings.MODEL_YAESU_FT817, "", "", "", "", 9600)
)
override val wavelogSettings: StateFlow<com.rtbishop.look4sat.core.domain.model.WavelogSettings> =
MutableStateFlow(com.rtbishop.look4sat.core.domain.model.WavelogSettings())
override val wavelogUploadSettings: StateFlow<com.rtbishop.look4sat.core.domain.model.WavelogUploadSettings> =
MutableStateFlow(com.rtbishop.look4sat.core.domain.model.WavelogUploadSettings())
override fun updateWavelogUploadSettings(settings: com.rtbishop.look4sat.core.domain.model.WavelogUploadSettings) = Unit
@@ -377,7 +376,7 @@ private class FakeSettingsRepoForSearch : ISettingsRepo {
override fun setSatelliteOffset(catnum: Int, offset: String) = Unit
override fun getAmSatCallsign(): String = ""
override fun setAmSatCallsign(callsign: String) = Unit
override fun updateWavelogSettings(settings: com.rtbishop.look4sat.core.domain.model.WavelogSettings) = Unit
override fun getWorkedGrids(): Set<String> = emptySet()
override fun setWorkedGrids(grids: Set<String>) = Unit
override fun getWorkedGridQsos(): Map<String, List<com.rtbishop.look4sat.core.domain.model.GridQso>> = emptyMap()
@@ -391,4 +390,12 @@ private class FakeSettingsRepoForSearch : ISettingsRepo {
override fun setLastLotwSyncDate(date: String) = Unit
override fun getLastLotwSyncCallsign(): String = ""
override fun setLastLotwSyncCallsign(callsign: String) = Unit
override fun getWavelogStations(): List<com.rtbishop.look4sat.core.domain.repository.WavelogStationInfo> = emptyList()
override fun setWavelogStations(stations: List<com.rtbishop.look4sat.core.domain.repository.WavelogStationInfo>) = Unit
override fun getWavelogSyncCursors(): Map<String, Long> = emptyMap()
override fun setWavelogSyncCursors(cursors: Map<String, Long>) = Unit
override fun getWavelogSyncUrl(): String = ""
override fun setWavelogSyncUrl(url: String) = Unit
override fun getLastWavelogSyncEpochMs(): Long = 0L
override fun setLastWavelogSyncEpochMs(value: Long) = Unit
}
@@ -0,0 +1,74 @@
/*
* Look4Sat-BA7OPF. Amateur radio satellite tracker and pass predictor.
* Copyright (C) 2026 BA7OPF.
* Based on Look4Sat by Arty Bishop and contributors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package com.rtbishop.look4sat.core.data.repository
import org.json.JSONObject
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Test
/** Parsing of the `get_contacts_adif` response envelope (transport-level wiring is exercised on device). */
class WavelogSyncRepositoryTest {
private val repository = WavelogSyncRepository()
@Test
fun successfulPageParsesRecordsAndCursor() {
val adif = "<ADIF_VER:5>3.1.7\n<EOH>\n" +
"<QSO_DATE:8>20260916<TIME_ON:4>0745<CALL:6>BG5JSB<GRIDSQUARE:4>EN52" +
"<MODE:2>FM<PROP_MODE:3>SAT<SAT_NAME:5>SO-50<EOR>\n"
val text = JSONObject()
.put("status", "successful")
.put("lastfetchedid", 42)
.put("exported_qsos", 1)
.put("adif", adif)
.toString()
val page = repository.parsePage(text)
assertNotNull(page)
assertEquals(42L, page!!.cursor)
assertEquals(1, page.exported)
assertEquals(1, page.records.size)
assertEquals("BG5JSB", page.records.single().theirCallsign)
assertEquals("EN52", page.records.single().theirGrid)
}
@Test
fun failedStatusIsRejected() {
assertNull(repository.parsePage("""{"status":"failed","reason":"missing api key"}"""))
}
@Test
fun missingCursorIsRejected() {
assertNull(repository.parsePage("""{"status":"successful","exported_qsos":0,"adif":null}"""))
assertNull(repository.parsePage("not json at all"))
}
@Test
fun emptyExportKeepsTheCursorAndYieldsNoRecords() {
val page = repository.parsePage("""{"status":"successful","lastfetchedid":7,"exported_qsos":0,"adif":null}""")
assertNotNull(page)
assertEquals(7L, page!!.cursor)
assertTrue(page.records.isEmpty())
}
}
Binary file not shown.